Commit graph

1734 commits

Author SHA1 Message Date
Vincent Nagel
51eb594695 added logging when context null in onPrefTreeClick 2020-04-20 21:45:32 -05:00
Vincent Nagel
5ba58e1ff5 setupTabs() if ageRestrictedContent pref changed 2020-04-20 21:45:32 -05:00
Vincent Nagel
bd1c43cd37 ageRestrictedContent cookie only sent for youtube
Now the age restricted content cookie is only sent when sending a
request to youtube. There's no need to remove the cookie when the
service changes because whether to add the cookie is determined by
looking at the url the request is being sent to.
2020-04-20 21:45:32 -05:00
Vincent Nagel
b1c310ce22 ageRestrictedContent first draft
Cookie updated whenever ageRestrictedContent setting is changed or
service is changed. Right now there is only a cookie for youtube, but
cookies for other services could be added in the future.

Problems with this approach: Even when the service is set to youtube,
the downloader doesn't only request youtube urls e.g. it also sends
reqeusts to i.ytimg.com, suggestqueries.google.com, and yt3.ggpht.com.
The ageRestrictedContent cookie is not normally sent when sending
requests to these other urls, so doing so might have unknown effects.
2020-04-20 21:45:32 -05:00
bopol
2e1a638a93 use nanojson instead of org.json 2020-04-20 11:02:45 +02:00
Tobias Groza
4b07caae90 Merge pull request #3345 from mitosagi/error-with-bookmarks
Fix repeated exceptions in Bookmarked Playlists
2020-04-19 22:00:31 +02:00
wb9688
d82c2d440c Merge pull request #3414 from Stypox/recaptcha
Fix ReCaptcha Activity for another type of recaptcha page
2020-04-19 19:49:01 +02:00
Stypox
8c862bd668 Enqueue on long click on background/popup in channel 2020-04-19 10:34:07 +02:00
Stypox
c62e363ba5 Save and restore cookies to/from preferences
So that the user does not have to solve a recaptcha every time he opens the app
2020-04-15 13:30:27 +02:00
Stypox
9620cf2051 Remove duplicate check if cookies are already present 2020-04-15 13:30:27 +02:00
Stypox
1de5323696 Fix recaptcha activity for another type of recaptcha page
Try to get cookies from pages even when they start loading, because non-html pages like ones with `pbj=1` never stop loading.
Try to extract the cookie directly from the redirection url, by looking at the field "google_abuse=".
Add `GOOGLE_ABUSE_EXEMPTION=` to the youtube recaptcha cookies.
2020-04-15 13:30:27 +02:00
wb9688
a44582d958 Merge pull request #3410 from wb9688/fix-restricted
Show error when video has age limit and setting is disabled
2020-04-11 09:44:25 +02:00
wb9688
2a7f240bb0 Hide tabs when a video is age restricted 2020-04-11 09:30:12 +02:00
Tobias Groza
fc02abc918 Merge pull request #3294 from mauriciocolli/fix-network-issues-detection
Fix detection of network related exceptions
2020-04-10 23:10:34 +02:00
Stypox
44fb0869b4 Fix checkstyle issues and improve code formatting
Also calculate differently the moved distance of a pointer: use euclidean and not manhattan geometry
2020-04-10 22:12:45 +02:00
Harshal Lele
2458d28244 formatting changes 2020-04-10 22:10:32 +02:00
Harshal Lele
9412c723f7 made formatting changes 2020-04-10 22:10:32 +02:00
Harshal Lele
feceb2bef8 changed popup resizing 2020-04-10 22:10:32 +02:00
Tobias Groza
4e10b6320d Merge pull request #3412 from mauriciocolli/improve-drawer-title-size-handling
Improve size handling of the drawer header title
2020-04-10 22:04:53 +02:00
Mauricio Colli
5d1a618caa Improve size handling of the drawer header title
Some devices, specially with custom fonts that changed the font width,
weren't being correctly adjusted before.
2020-04-10 10:31:28 -03:00
wb9688
06aa8478b3 Show error when video has age limit and setting is disabled 2020-04-10 15:29:48 +02:00
wb9688
5e19035317 Use suggested layout for search filters 2020-04-10 10:35:54 +02:00
wb9688
c65e8a3a9e Add ability to translate YouTube Music search options 2020-04-10 10:35:54 +02:00
Stypox
149e274560 Use ITEM_COUNT_UNKNOWN 2020-04-10 10:35:54 +02:00
Stypox
8674c08ae0 Use "mini" stream count alternatives for info items
Note: more_than_100_videos_mini and infinite_videos_mini are untranslatable
2020-04-10 10:35:54 +02:00
Stypox
78d00d2db2 Also use localizeStreamCount() in local items 2020-04-10 10:35:54 +02:00
Stypox
95d3550aed Detect ITEM_COUNT_* in localizeStreamCount()
ITEM_COUNT_INFINITE and ITEM_COUNT_MORE_THAN_100.
Use localizeStreamCount in PlaylistFragment and PlaylistItemHolder
2020-04-10 10:35:54 +02:00
Stypox
f8f035275a Add support for INFINITE_ and MORE_THAN_100_ITEMS in playlists 2020-04-10 10:35:53 +02:00
bopol
3ab53c9c80 handle ContentNotSupportedException for Channel Fragment (when an user has no video tab) 2020-04-10 09:12:29 +02:00
bopol
65d1813976 handle ContentNotSupportedException in ExtractorHelper.handleGeneralException() 2020-04-09 23:58:01 +02:00
bopol
b659660867 handle ContentNotSupportedException in BaseStateFragment
thus not supported soundcloud streams (e.g. hls streams) don't crash
anyore
2020-04-09 23:58:01 +02:00
wb9688
3bc2b38296 Merge pull request #3395 from kapodamy/checkstyle-warnings
remove some warnings issued by checkstyle
2020-04-09 21:08:53 +02:00
Mauricio Colli
40508788dd Use exception utils in network error detection throughout the app 2020-04-09 13:22:24 -03:00
Mauricio Colli
9ff7c90a9c Move exception utils to a separate class and add tests for it 2020-04-09 13:22:18 -03:00
wb9688
213b0dc176 Suppress remaining Checkstyle errors 2020-04-09 17:24:43 +02:00
Tobias Groza
365f968f1b Merge pull request #3288 from XiangRongLin/save-playback
Save and restore playback parameters into/from preferences
2020-04-08 21:38:53 +02:00
kapodamy
3be6402041 checkstyle
* drop unused methods
* split blobs
* make no final parameters
2020-04-08 12:08:01 -03:00
wb9688
2ea36ceddf Merge pull request #3276 from lnjX/fix/the-the-typo
ThemeHelper: Fix 'the the' typo
2020-04-07 09:25:00 +02:00
wb9688
3c7a1fd4a0 Merge branch 'dev' into fix/the-the-typo 2020-04-07 09:17:10 +02:00
Mauricio Colli
aee41148b9 Fix visibility of group sort button in the subscriptions fragment 2020-04-05 16:57:28 -03:00
Xiang Rong Lin
6472a5d69f Save and restore playback parameters into/from preferences
Playback parameters are speed, pitch and skip silence.
Remove parameters being passed on as intent to the player, since the parameters can be restored from the preferences instead.

# Conflicts:
#	app/src/main/java/org/schabi/newpipe/player/BasePlayer.java
2020-04-05 17:46:49 +02:00
Mauricio Colli
17b4a97a3c Avoid unnecessary changes to the upload date of saved streams
The upload date was being updated regardless if the new one had more
precision or not, this caused items on the feed to jump around when the
user opened one of them.

This changes it to only update when the existent upload date is null or
the new one has a higher precision (i.e. is not an approximation).
2020-04-05 10:57:54 -03:00
mitosagi
fcfb50333d Make null sortable 2020-04-05 17:26:00 +09:00
Tobias Groza
4bda491b79 Merge pull request #3344 from wb9688/checkfornewappversiontask-downloaderimpl
Use DownloaderImpl in CheckForNewAppVersionTask
2020-04-04 20:11:39 +02:00
wb9688
7962f87e66 Clean up CheckForNewAppVersionTask 2020-04-04 19:34:13 +02:00
wb9688
8b2bc17723 Revert some more changes 2020-04-03 15:48:38 +02:00
wb9688
b283dccdfd Use DownloaderImpl in CheckForNewAppVersionTask 2020-04-02 20:13:05 +02:00
wb9688
4b196c6a8c Use Checkstyle for org.schabi.newpipe.streams as well 2020-04-02 16:48:57 +02:00
wb9688
9c8349a8ed Move things back to its original place 2020-04-02 15:57:50 +02:00
wb9688
ac264464ef Improve code style to be more consistent 2020-04-02 15:57:50 +02:00