Commit graph

308 commits

Author SHA1 Message Date
Stypox
b8f7c7173d Merge pull request #6536 from TacoTheDank/moar-onactivityresult
More onActivityResult deprecation fixes
2021-07-18 10:24:00 +02:00
Tobi
47e6dc7d42 Merge pull request #6531 from XiangRongLin/immediat_pref_commit
Remove option to immediately commit pref changes on import
2021-07-14 09:48:58 +02:00
Mohammed Anas
e055b84206 Don't enable SAF on Fire TV (#6516) 2021-06-20 19:01:06 +00:00
TacoTheDank
f48e1d1da9 Fix onActivityResult deprecation in DownloadSettingsFragment 2021-06-20 14:11:00 -04:00
XiangRongLin
ca07dff0e3 Remove variable ContentSettingsFragment.lastImportExportDataUri
Instead pass the value through the methods as parameter
2021-06-20 09:30:59 +02:00
XiangRongLin
b78d987bcb Resolve sonar issues in ContentSettingsFragment
https://sonarcloud.io/organizations/teamnewpipe/rules?open=java%3AS2885&rule_key=java%3AS2885

https://sonarcloud.io/organizations/teamnewpipe/rules?open=java%3AS112&rule_key=java%3AS112
2021-06-20 09:30:59 +02:00
XiangRongLin
ff8139f3b3 Remove option to immediately commit pref changes on import
System is now not restarted with `System.exit(0)`.
Instead it is done properly by finishing the activity and restarting the activity. This allows preference changes which are queued up asynchronously through `apply` to be applied.
2021-06-20 09:17:55 +02:00
TacoTheDank
2b1d11dc60 Annotate some overridden methods and parameters as NonNull 2021-06-19 18:37:02 -04:00
Stypox
4a963858ba Merge pull request #6394 from TacoTheDank/androidx-fragment-134
Update AndroidX Fragment to 1.3.4
2021-06-18 13:14:30 +02:00
danielmbutler
d58e7e0cb1 Replaced System.Exit calls with FinishAffinity and Start Activity calls
Implemented "RestartApp" method defined in NavigationHelper.java.
 This method is used in ExitActivity.java and ContentSettingsFragment.java
2021-06-17 17:18:15 +01:00
TacoTheDank
f91b35a718 Fix onActivityResult deprecation in ContentSettingsFragment 2021-06-15 22:08:55 -04:00
TacoTheDank
c1e0b877f5 Fix some older deprecations from previous Fragment versions 2021-06-15 22:08:25 -04:00
Stypox
7d41b3415d Merge pull request #6346 from Imericxu/tabs-style-check
Resolve Tabs style checks
2021-06-08 14:49:14 +02:00
Stypox
4072fd0ab1 Update app/src/main/java/org/schabi/newpipe/settings/tabs/Tab.java 2021-06-08 14:45:00 +02:00
Stypox
6204608c60 Update app/src/main/java/org/schabi/newpipe/settings/tabs/Tab.java 2021-06-08 14:44:54 +02:00
Stypox
2d92f18471 Reimplement storing backup import/export path
#6319 and #6402 were reverted before adding SAF changes, and have been readded at the end of SAF changes
2021-06-08 10:41:24 +02:00
Stypox
3399ed2b30 Pass mime type so that SAF treats file extension correctly 2021-06-08 10:40:45 +02:00
Stypox
907c3b77f8 Improve SAF switch descriptions in settings 2021-06-08 10:40:45 +02:00
Stypox
e127083deb Add setting migration to promote using SAF 2021-06-08 10:40:45 +02:00
wb9688
c871d765f3 Fix non-SAF actions 2021-06-08 10:40:44 +02:00
wb9688
1195867a36 Use file picker for export DB 2021-06-08 10:40:44 +02:00
wb9688
995264e5e2 Move Stored(File|Directory)Helper into NewPipe 2021-06-08 10:40:44 +02:00
wb9688
4e133a3599 Support SAF properly 2021-06-08 10:40:44 +02:00
Stypox
84709eb620 Revert all commits related to ContentSettingsFragment
Revert "Annotate methode parameters as NonNull"
This reverts commit af92c3ed4f.

Revert "Commit path immediately when import backup"
This reverts commit c3d9c4bb3f.

Revert "Set ImportExportDataPath only on successful import"
This reverts commit a4bc61a7d0.

Revert "Set ImportExportDataPath only on successful export"
This reverts commit 372d7a7832.

Revert "Invert if condition in ContentSettingsFragment.setImportExportDataPath for better readability"
This reverts commit 2877c43ecb.

Revert "Move ContentSettingsFragment.isValidPath to helpers and add unit test for it."
This reverts commit 15873d53c4.

Revert "Save backup import/export location for feature import/exports"
This reverts commit 01f05e2f46.

Remove FilePathHelperTest file
2021-06-08 10:40:44 +02:00
XiangRongLin
af92c3ed4f Annotate methode parameters as NonNull 2021-05-31 15:09:57 +02:00
XiangRongLin
c3d9c4bb3f Commit path immediately when import backup 2021-05-31 12:40:14 +02:00
XiangRongLin
a4bc61a7d0 Set ImportExportDataPath only on successful import
Also set the folder instead of the file itself as path
2021-05-31 12:38:21 +02:00
XiangRongLin
372d7a7832 Set ImportExportDataPath only on successful export 2021-05-31 12:36:21 +02:00
Eric Xu
ad2e1dcf03 Add PlaylistTab.hashCode() matching equals 2021-05-26 12:01:30 -04:00
Eric Xu
9b4c7e6644 Refactor PlaylistTab.equals 2021-05-26 12:01:30 -04:00
Eric Xu
6ab457e51c Add ChannelTab.hashCode() matching equals 2021-05-26 12:01:30 -04:00
Eric Xu
346df8a36c Refactor ChannelTab.equals 2021-05-26 12:01:30 -04:00
Eric Xu
68f8c38445 Add KioskTab.hashCode() matching equals 2021-05-26 12:01:30 -04:00
Eric Xu
154e672c91 Refactor KioskTab.equals 2021-05-26 12:01:30 -04:00
Eric Xu
fe5e1df9c2 Add Tab.hashCode() to go with equals 2021-05-26 12:01:30 -04:00
Eric Xu
12425eaadc Refactor equals method 2021-05-26 12:01:30 -04:00
Alireza Tofighi
2877c43ecb Invert if condition in ContentSettingsFragment.setImportExportDataPath for better readability 2021-05-21 20:24:57 +04:30
Alireza Tofighi
15873d53c4 Move ContentSettingsFragment.isValidPath to helpers and add unit test for it. 2021-05-21 20:21:58 +04:30
Alireza Tofighi
01f05e2f46 Save backup import/export location for feature import/exports 2021-05-17 21:57:27 +04:30
TacoTheDank
7640aa85c3 Migrate rest of AlertDialogs to AppCompat 2021-04-04 10:26:38 -04:00
krlvm
ef0999b9c3 Merge branch 'dev' into daynight 2021-04-03 00:08:26 +03:00
Stypox
5e7b3c811f Fix random NullPointerException in NotificationActionsPreference 2021-03-31 09:12:47 +02:00
krlvm
92e8c18177 Cleanup 2021-03-30 00:03:30 +03:00
krlvm
abad71e292 Fix colors in setting fragments, cleanup 2021-03-29 21:19:17 +03:00
krlvm
9bb8f65bef Fix colors in PeerTube Settings Fragment 2021-03-28 19:36:07 +03:00
Stypox
e2be22edb0 Merge pull request #5879 from TacoTheDank/clean-oncreatepreferences
Clean up unnecessary onCreate in settings fragments
2021-03-28 10:48:10 +02:00
krlvm
a8de222577 Fix Dark elements in Light Theme 2021-03-27 17:46:05 +03:00
Stypox
c2b5790fc6 Merge pull request #5882 from TacoTheDank/fragmentcontainerview
Replace FrameLayout with FragmentContainerView where applicable
2021-03-27 08:31:32 +01:00
krlvm
c509ecac47 Migrate to DayNight Theme 2021-03-26 23:08:25 +03:00
Stypox
d605441320 Fix settings switches are not red anymore
Reverts part of e8baee2a5e
2021-03-24 10:16:24 +01:00