Sulkta-OSS/straw
3
0
Fork 0
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity Actions
8891 commits 2 branches 0 tags 50 MiB
Commit graph

2642 commits

Author SHA1 Message Date
XiangRongLin
372d7a7832 Set ImportExportDataPath only on successful export 2021-05-31 12:36:21 +02:00
Tobi
efaea39ecc Merge pull request #6118 from sauravrao637/errorHandlingInSubcribe 
Error handling in subscribe() in DownloadDialog
 2021-05-29 11:30:36 +02:00
Tobi
6b70576d87 Merge pull request #6353 from Imericxu/fix-pasting-rich-text-in-search 
Fix unwanted rich text formatting when pasting
 2021-05-29 09:12:07 +02:00
Tobi
5438064555 Merge pull request #6385 from sauravrao637/6371 
Option for download is redundant and thus removed when linkType is CHANNEL or PLAYLIST
 2021-05-28 14:23:04 +02:00
camo0112
46e41ab913 Option for download is redundant and thus removed when linkType is CHANNEL or PLAYLIST 2021-05-28 03:38:53 +05:30
Zhiheng Xu
8b6da2f3ba Simplify code 2021-05-26 12:01:58 -04:00
Zhiheng Xu
0bb046dc7b Add comment 2021-05-26 12:01:58 -04:00
Zhiheng Xu
0e2f4f1922 Add formatting removal on paste for search 
Closes #5912
 2021-05-26 12:01:58 -04:00
Eric Xu
ad2e1dcf03 Add PlaylistTab.hashCode() matching equals 2021-05-26 12:01:30 -04:00
Eric Xu
9b4c7e6644 Refactor PlaylistTab.equals 2021-05-26 12:01:30 -04:00
Eric Xu
6ab457e51c Add ChannelTab.hashCode() matching equals 2021-05-26 12:01:30 -04:00
Eric Xu
346df8a36c Refactor ChannelTab.equals 2021-05-26 12:01:30 -04:00
Eric Xu
68f8c38445 Add KioskTab.hashCode() matching equals 2021-05-26 12:01:30 -04:00
Eric Xu
154e672c91 Refactor KioskTab.equals 2021-05-26 12:01:30 -04:00
Eric Xu
fe5e1df9c2 Add Tab.hashCode() to go with equals 2021-05-26 12:01:30 -04:00
Eric Xu
12425eaadc Refactor equals method 2021-05-26 12:01:30 -04:00
Zhiheng Xu
acbe0bfc94 Change shuffle() guard to check for size <= 2 
After testing the app, I realized that shuffling a queue with size 2
does nothing
 2021-05-24 12:20:19 -04:00
Zhiheng Xu
6da5d1585d Remove redundant clearing of list 2021-05-24 12:20:19 -04:00
Zhiheng Xu
e29058412e Refactor shuffle and update documentation 
- Add early return for invalid sizes to shuffle

 - Rename variables to be more descriptive

 - Refactor moving list element, removing unnecessary operations

 - Unwrap if clause for adding to history because the condition is
   guaranteed by the guard clause

 - Inline the value 0 for the ReorderEvent

 - Update documentation to reflect new changes
 2021-05-24 12:20:19 -04:00
Eric Xu
3a8aa90c72 Rearrange fields 
Final fields should be arranged first
 2021-05-24 12:20:19 -04:00
Eric Xu
158791043e Resolve TODO in indexOf(...) 
PlayQueueItem overrides equals and hashCode, so using indexOf is
perfectly fine.
 2021-05-24 12:20:19 -04:00
Eric Xu
784c78c89e Rewrite setIndex(int) to pass unit tests 
Original did not cover the case of when streams is empty and
documentation does not specify any input restrictions.

There's an ambiguity with broadcasting an event between the
documentation and the actual code (see TODO).
 2021-05-24 12:20:19 -04:00
Eric Xu
55da632641 Refactor assignments to field declaration 
Assignments that don't require the constructor can be moved out.
 2021-05-24 12:20:19 -04:00
Eric Xu
78ff6485a2 Add hashCode() to match equals(other) 2021-05-24 12:20:19 -04:00
Eric Xu
61e2ab4d80 Refactor streams to initialize with values 2021-05-24 12:20:19 -04:00
Eric Xu
8b2b3f8fe2 Refactor ArrayList fields to List 2021-05-24 12:20:19 -04:00
Eric Xu
b4b6726ec8 Refactor and optimize equals 
- Remove multiple casts of obj

 - Simply use object equals on the streams because PlayQueueItem’s
   equals already compares urls
 2021-05-24 12:20:19 -04:00
TobiGr
14a6130a44 Add support for PeerTube HLS streams 2021-05-23 11:53:35 +02:00
XiangRongLin
51026f6450 Merge pull request #6319 from ATofighi/feat-6039-store-backup-location 
Save backup import/export location for future import/exports
 2021-05-21 21:08:33 +02:00
Alireza Tofighi
2877c43ecb Invert if condition in ContentSettingsFragment.setImportExportDataPath for better readability 2021-05-21 20:24:57 +04:30
Alireza Tofighi
15873d53c4 Move ContentSettingsFragment.isValidPath to helpers and add unit test for it. 2021-05-21 20:21:58 +04:30
Alireza Tofighi
01f05e2f46 Save backup import/export location for feature import/exports 2021-05-17 21:57:27 +04:30
XiangRongLin
4a6ee0cea5 Merge pull request #6308 from mhmdanas/make-minor-changes 
Make some minor changes
 2021-05-17 12:14:00 +02:00
XiangRongLin
0458e05fb9 Merge pull request #6312 from ATofighi/fix-6298-report-page-back-not-working 
Fix ErrorActivity actionbar back button not working
 2021-05-17 12:12:12 +02:00
Isira Seneviratne
31eb99034f Convert Converters to a Kotlin object. 2021-05-16 11:14:15 +05:30
Isira Seneviratne
0755c854db Rename .java to .kt 2021-05-16 11:14:15 +05:30
Alireza Tofighi
5604194123 Fix ErrorActivity actionbar back button not working 
The issue is because of R.id.home != android.R.id.home
 2021-05-16 02:19:52 +04:30
mhmdanas
d35974a352 Put show channel details option in more long-press menus 2021-05-15 19:20:27 +03:00
mhmdanas
1f98ef54de Make some minor changes 2021-05-15 18:48:16 +03:00
Robin
6debb784b7 TEST: Downgrade ExoPlayer to 2.12 2021-05-14 14:47:53 +02:00
Robin
c1dc93e2d7 Fixed checkstyle 2021-05-14 12:15:48 +02:00
Robin
9cbcb38f47 Add debug option to disable media tunneling 2021-05-14 12:05:52 +02:00
Saurav Rao
f81cd98fb6 Fix trying to delete object not in list (#6127) 
* fix trying to delete object by index -1

* correction in checkstyle-supressions.xml

Co-authored-by: camo0112 <56369484+camo0112@users.noreply.github.com>
 2021-05-12 14:33:00 +02:00
litetex
63bfdfc242 Fixed player not automatically playing (#6266) 
* Fixed player not automatically playing

Should also fix https://github.com/TeamNewPipe/NewPipe/issues/6179

* Added comment
 2021-05-12 10:20:39 +02:00
evermind
3bd65af9c0 fix Rotation crash on „Video not available“ page (#5941) 
The EmptyFragment should not have a constructor at all.
Now a static methods creates the Fragment and arguments
are handled via a Bundle.
 2021-05-05 08:55:54 +02:00
ix5
393491281e Downloader: Deleter: Dismiss previous Snackbars 
Bug:
In Downloader view, while deleting items, Snackbars at the
bottom of the UI keep queuing up. You need to wait for all
of them to dismiss themselves for files to actually be
deleted. If you close NewPipe before all snackbars are
dismissed, your files will not be deleted and show up again
next time you start NewPipe.

Fix:
When running append(), trigger the commit() action
immediately and cancel all delayed callbacks for commit().

This prevents Snackbars from stacking up in reverse order.

Fixes: https://github.com/TeamNewPipe/NewPipe/issues/5660
 2021-05-04 19:44:09 +02:00
Tobi
a885f75ad2 Merge pull request #6152 from Isira-Seneviratne/Use_Animator_addListener 
Use Animator.addListener() extension.
 2021-05-04 19:37:03 +02:00
Robin
7210546d6e Fix: fragmentSize is below the minimum (#6238) 
noticed logs " CacheDataSink: fragmentSize is below the minimum recommended value of 2097152. This may cause poor cache performance.

this fixes the issue by using ExoPlayers MIN_RECOMMENDED_FRAGMENT_SIZE. Unfortunately that field is private:
aeb306a164/library/core/src/main/java/com/google/android/exoplayer2/upstream/cache/CacheDataSink.java (L123)
 2021-05-04 19:08:25 +02:00
Tobi
09c45b8502 Merge pull request #6189 from mhmdanas/fix-some-warnings 
Fix some warnings
 2021-05-04 18:54:17 +02:00
Tobi
b188cb9d38 Merge pull request #5997 from TeamNewPipe/reChaptcha 
Do not set reCaptcha cookie when there is no cookie stored
 2021-05-04 18:53:12 +02:00