Mahendran
bf63b3aca2
Thumbnails used in NewPipe are small (list/grid) mode. This PR facilitates full width thumbnails and dubbed as card mode.
2023-01-15 22:32:03 +05:30
Stypox
7ea16cfc96
Merge pull request #9555 from Marius1501/make_the_channel_images_bigger
...
Made the channel-images in the grid list bigger
2023-01-15 15:16:09 +01:00
Stypox
29fcae2325
Merge pull request #8894 from Isira-Seneviratne/WindowCompat
...
Use WindowCompat.
2023-01-15 15:14:05 +01:00
Stypox
c5d709ef20
Merge pull request #9678 from Marius1501/change_whats_new_icon
...
Changed the What's New icon
2023-01-15 15:12:26 +01:00
Stypox
1433ad87d4
Merge pull request #7725 from AudricV/add-long-press-actions-on-hashtags-and-links-in-descriptions
...
Add long press action on hashtags and web links in descriptions
2023-01-15 14:06:32 +01:00
Stypox
0470fc2853
Create text subpackage in util
2023-01-15 11:51:07 +01:00
AudricV
6de5a8cf04
Add ability to copy hashtags, URLs and timestamps in descriptions on long-press
...
This commit adds the ability to copy to clipboard hashtags, URLs and timestamps
when long-pressing them.
Some changes in our TextView class related to text setting have been required
and metadata items are now using a NewPipeTextView instead of a standard
TextView.
Six new classes have been added:
- a custom LinkMovementMethod class;
- a custom ClickableSpan class, LongPressClickableSpan, in order to set a long
press event;
- a class to avoid code duplication in CommentTextOnTouchListener, TouchUtils;
- three implementations of LongPressClickableSpan used when linkifying text:
- HashtagLongPressClickableSpan for hashtags;
- TimestampLongPressClickableSpan for timestamps;
- UrlLongPressClickableSpan for URLs.
2023-01-15 11:40:27 +01:00
ge78fug
440b3e72d4
Made the channel-images in the grid list bigger
...
Also improved the handling of additional information (expanded description, video count, subscriber count)
2023-01-15 10:50:20 +01:00
Isira Seneviratne
f7e0df8fb5
Replace the system UI visibility flags with WindowCompat calls.
2023-01-15 05:44:45 +05:30
Stypox
cd44aad907
See if playlists already contain a stream from db
2023-01-14 18:01:48 +01:00
Jared Fantaye
938cbfc16a
Added the number of duplicates to the toast text.
2023-01-14 18:01:48 +01:00
Jared Fantaye
f558a4a0d2
Removed the duplicate dialog and added another toast option
2023-01-14 18:01:48 +01:00
Jared Fantaye
7a3b3452c4
Fixed the functionality, improved performance & general code cleanup
2023-01-14 18:01:47 +01:00
Jared Fantaye
8f38f02cd3
Continued working on a way to show that items are already in a playlist
2023-01-14 18:01:47 +01:00
Jared Fantaye
40522dbebf
Started working on a way to show that items are already in a playlist
2023-01-14 18:01:47 +01:00
Jared Fantaye
2caccef5cd
Implemented a warning before adding duplicate to playlist.
2023-01-14 18:01:46 +01:00
ge78fug
03618ea4d9
Chenged the name of the icon
2023-01-14 09:21:37 +01:00
Isira Seneviratne
4760eaffae
Update desugar_jdk_libs to 2.0.0.
2023-01-14 11:00:00 +05:30
Jared Fantaye
82d74d18ee
Implemented the "remove duplicates" feature.
2023-01-13 21:35:22 +01:00
ge78fug
9fa2c538d9
Chenged the What's New icon
2023-01-13 16:33:45 +01:00
Stypox
b5faaa7f75
Merge pull request #9664 from Marius1501/whats_new_section_to_default_tabs
...
Added the "What's New"-section to the default tabs
2023-01-13 13:25:02 +01:00
Stypox
f7fe8d0e57
Merge pull request #9642 from Jared234/8582_empty_playlists_not_shown
...
Fixed a bug that prevented the display of multiple empty playlists
2023-01-13 13:20:42 +01:00
Stypox
efaf785972
Merge pull request #9445 from Jared234/9122_remove_watched_bug
...
Fixed a bug that incorrectly removed videos from a playlist when using the "Remove Viewed" dialog
2023-01-12 23:45:48 +01:00
Jared Fantaye
71be67f17d
Fixed the "Remove Watched" bug
...
Reverted changes and fixed bug in a different way
2023-01-12 23:44:26 +01:00
Stypox
52be821088
Merge pull request #9523 from Jared234/9468_permanently_set_thumbnail
...
Allow the user to permanently set a thumbnail
2023-01-12 23:27:50 +01:00
Stypox
55726df2c4
Merge pull request #8886 from Isira-Seneviratne/Remove_Runnable_variables
...
Remove Runnable variables for Handlers.
2023-01-12 15:34:12 +01:00
Isira Seneviratne
f8e6962849
Remove Runnable variables for Handlers.
2023-01-12 15:30:19 +01:00
Stypox
48d181d9ae
Merge pull request #9619 from Redirion/avoidreflectionifpossible
...
Check availability of Samsung DeX only on Samsung devices
2023-01-12 12:06:19 +01:00
Stypox
2def965f65
Fix toast crash on API 33
...
You shouldn't call getView() on toasts.
Also simplified some duplicate code.
2023-01-12 11:39:25 +01:00
Stypox
9bf4de43ca
Merge pull request #9653 from petlyh/fix-popup-crash
...
Ask for permission when enqueuing in a popup
2023-01-12 11:24:21 +01:00
Stypox
62fdd08ccf
Merge pull request #9499 from pratyaksh1610/branch-9466
...
Added Language suffix for subtitle downloads
2023-01-11 19:46:51 +01:00
Stypox
db05801c5b
UX improvements: keep user edits & do not reset cursor
2023-01-11 19:45:55 +01:00
ge78fug
fa85b7c417
Added the "What's New"-section to the default tabs
2023-01-11 16:06:11 +01:00
Stypox
b6b09b68af
Actually there is no need to use flatMap
...
`null` values returned in the lambda are converted to empty `Optional`s in the `map` method: https://developer.android.com/reference/java/util/Optional#map(java.util.function.Function%3C?%20super%20T,%20?%20extends%20U%3E)
2023-01-11 15:26:46 +01:00
Stypox
0f0a1d36d8
Merge pull request #9135 from devlearner/routeractivity-screen-rotate
...
Improve screen rotation handling in Open action menu
2023-01-11 15:20:47 +01:00
Stypox
3dde6c70bc
Use Optional for simpler code
2023-01-11 15:14:18 +01:00
devlearner
345ee656cf
Improve showing of toast
...
We provide visual feedback via a toast to the user that, well, they're supposed to wait; but with the benefit of the cache openAddToPlaylistDialog() may return (almost) immediately, which would render the toast otiose (if not a bit confusing). This commit improves that by cancelling the toast once the wait's over
... (by 'abusing' RxJava's ambWith();
ref on compose() and Transformer: https://blog.danlew.net/2015/03/02/dont-break-the-chain/
and for me, first time laying my hands at RxJava so kindly bear with me; open for suggestions)
2023-01-11 14:53:48 +01:00
devlearner
a6381ce3b3
Utilize Lifecycle observer
...
I thought it would have required an extra dependency; apparently that doesn't seem to be the case...
2023-01-11 14:53:48 +01:00
devlearner
cedc02bd73
Oops, added back missing return;
2023-01-11 14:53:48 +01:00
devlearner
ebf314b7ab
Fix Sonar reported code smell
2023-01-11 14:53:48 +01:00
devlearner
9a334187c6
Skip REORDER_TO_FRONT trick which doesn't seem to work on newer Androids
...
probably due to background restrictions on Android 10+
2023-01-11 14:53:48 +01:00
devlearner
06351cc12c
Utilize a retained fragment to safekeep network requests in flight
...
pending result for openAddToPlaylistDialog() and openDownloadDialog()
Despite marked deprecated, setRetainInstance(true) is probably our best bet (since a ViewModel is probably too overkill for our present purpose)
2023-01-11 14:53:48 +01:00
devlearner
fcd556e555
Improve (un)registering FragmentLifecycleCallbacks
...
to avoid adding it multiple times and ensure proper cleanup
2023-01-11 14:53:48 +01:00
devlearner
c9ff6b1e56
Address LayoutParams.FLAG_NOT_TOUCHABLE restriction on Andriod 12+
2023-01-11 14:53:48 +01:00
devlearner
e7a61358f7
Ensure our transparent activity doesn't block touch events to underlying windows
...
so we won't hold up UI while fetching media info for Add to Playlist or Download actions
lest user might think it freezes when in fact a network request is underway
2023-01-11 14:53:48 +01:00
devlearner
2612c1cdf3
Also show toast in openDownloadDialog()
...
and lengthened a bit to inform user to wait...
2023-01-11 14:53:48 +01:00
devlearner
0d430f99e6
Try to amicably handle DialogFragment in FragmentManager when recreated from orientation change
...
- Handle finish() call instead of passing around callbacks to setOnDismissListener()
- Don't start over again if returning to DialogFragment before orientation change
2023-01-11 14:53:48 +01:00
devlearner
c173e04aa4
Don't finish() to allow recreate
...
when orientation change is on foot
2023-01-11 14:53:48 +01:00
devlearner
94cc1f2982
Set up theme/locale before super.create()
...
This seems to solve a bug where the Open action menu dialog does not appear the first time on cold start on older Android (8.0).
This is also the order of things in MainActivity and probably good practice.
2023-01-11 14:53:48 +01:00
Stypox
b17415a88e
Merge pull request #9285 from Isira-Seneviratne/Optional_cleanup
...
Clean up Optional-related code.
2023-01-11 14:52:25 +01:00