AudricV
5af4db41ae
Hide the upload date element on the About tab
...
This empty element should be always hidden for this tab, as there is no upload
date available for channels.
2023-09-18 23:22:32 +02:00
AudricV
88419ec7b1
Always show the About tab and support having no description
2023-09-18 23:22:32 +02:00
TobiGr
43054e6d67
Extract actual feed loading code into separate method
...
Increase readability
2023-09-18 23:22:32 +02:00
TobiGr
2f65b4f823
Add missing @Override annotations to setupMetadata() implementations
2023-09-18 23:22:32 +02:00
Stypox
43097e4486
Update NewPipeExtractor and adapt imports
2023-09-18 23:22:32 +02:00
Stypox
7602473e53
Fix wrongly themed channel header
...
Since it is embedded in the app bar and has red as background color, it should be themed in the same way as the toolbar.
2023-09-18 23:22:32 +02:00
Stypox
e0e4265a19
Use consistent name for livestreams tab in settings keys
2023-09-18 23:22:32 +02:00
Stypox
5325226b33
Fix loading feed when a channel tab is empty
2023-09-18 23:22:32 +02:00
Stypox
9a70693152
Show snackbar with feed loading errors
2023-09-18 23:22:32 +02:00
Stypox
abbfbce6f9
Make channel banner placeholder match YouTube's size
...
YouTube's "Desktop Max" thumbnails are 2560x423, while our previous placeholder banner was 2550x427. The extractor actually returns a lower resolution "Desktop Max" banner at 1060x175, but the ratio wrt 2560x423 is off by ~0.1%
The PNG was optimized with OptiPNG
2023-09-18 23:22:32 +02:00
Stypox
b26c5a7d5c
Improve placeholder channel banner handling
...
Now the placeholder gets hidden if there is no banner url or the user disabled images, to save space
2023-09-18 23:22:32 +02:00
Stypox
486664f293
Add avatar and bannner URLs to channel About tab
2023-09-18 23:22:32 +02:00
Stypox
5613a89099
Add space above channel description (About tab)
2023-09-18 23:22:32 +02:00
ThetaDev
a5298ce994
add channel banner placeholder
2023-09-18 23:22:32 +02:00
ThetaDev
36b11db357
feat: filter fetched channel tabs
2023-09-18 23:22:32 +02:00
ThetaDev
9661774a05
update NPE
2023-09-18 23:22:32 +02:00
ThetaDev
8f7cbc93ef
feat: add playlist controls to channel tab
2023-09-18 23:22:32 +02:00
Stypox
b900ddaadf
Fix some code smells
2023-09-18 23:22:32 +02:00
Stypox
fc402a8742
Fix channel tabs in main page setting title themselves
2023-09-18 23:22:32 +02:00
Stypox
aa4ec2f39e
Channels are now an Info
...
The previous "main" tab is now just a normal tab returned in getTabs().
Various part of the code that used to handle channels as ListInfo now either take the first (playable, i.e. with streams) tab (e.g. the ChannelTabPlayQueue), or take all of them combined (e.g. the feed).
2023-09-18 23:22:32 +02:00
ThetaDev
a735063c5c
fix: limit channel header height
2023-09-18 23:22:32 +02:00
ThetaDev
6c60ef9a9c
fix: notification menu option disappears when switching tabs
2023-09-18 23:22:32 +02:00
Stypox
559a1a46e1
Move channel header to collapsible app bar
2023-09-18 23:22:32 +02:00
ThetaDev
7a99f4910d
fix: NPE in ChannelFragment::onSaveInstanceState
2023-09-18 23:22:32 +02:00
ThetaDev
59426378f1
refactor: rename ChannelInfo to ChannelAbout
...
fix: localize about tab name
2023-09-18 23:22:32 +02:00
ThetaDev
397234a40f
cleanup: remove empty constructor from ChannelFragment
2023-09-18 23:22:31 +02:00
ThetaDev
58d384cbab
remove fragment_channel_info
2023-09-18 23:22:31 +02:00
ThetaDev
243145cefd
update extractor
2023-09-18 23:22:31 +02:00
ThetaDev
13496f4533
refactor: common code from ChannelInfo/Description -> BaseInfoFragment
2023-09-18 23:22:31 +02:00
ThetaDev
37b7a46c57
update NewPipeExtractor
2023-09-18 23:22:31 +02:00
ThetaDev
773a6a8c7e
fix: channel tab title not being set
2023-09-18 23:22:31 +02:00
ThetaDev
72968fbefe
fix: ChannelFragment: save last tab
2023-09-18 23:22:31 +02:00
ThetaDev
cd797a6bef
refactor: adjustments to updated tab extractor API
2023-09-18 23:22:31 +02:00
ThetaDev
ca9102dd4c
fix: cache channel data
2023-09-18 23:22:31 +02:00
ThetaDev
bfce26fddc
fix: missing album tab key
2023-09-18 23:22:31 +02:00
ThetaDev
bf81bca9fd
feat: add album tab
2023-09-18 23:22:31 +02:00
ThetaDev
5ce45cd4f2
fix: remember selected channel tab on screen rotation
2023-09-18 23:22:31 +02:00
ThetaDev
1b0528870a
feat: add option to hide channel tabs
2023-09-18 23:22:31 +02:00
ThetaDev
81472c3969
fix: scrollable channel description
2023-09-18 23:22:31 +02:00
ThetaDev
53d9fa2fe6
fix: add progress spinners
2023-09-18 23:22:31 +02:00
ThetaDev
5d3bf427a3
feat: prettier channel info page
2023-09-18 23:22:31 +02:00
ThetaDev
c32feb3624
fix: handle unsupported content
2023-09-18 23:22:31 +02:00
ThetaDev
4e6b72dc8e
fix: get notified menu option on all tabs
2023-09-18 23:22:31 +02:00
ThetaDev
11f83b8e24
feat: add channel tabs
2023-09-18 23:22:31 +02:00
Rishab Aggarwal
04b7fe4939
Improved downloading experience ( #10407 )
...
* added LoadingDialog for improving download experience
* [LoadingDialog] Apply some review comments and make title customizable.
* removed permission handling from loading Dialog
* fix checks
* remove <p> Tag from first sentence
---------
Co-authored-by: rishabaggarwal <Rishabaggarwal@sharechat.com>
Co-authored-by: TobiGr <tobigr@users.noreply.github.com>
2023-09-18 05:24:03 +05:30
TobiGr
25034bb1b3
Add documentation to increase maintainablilty
...
Rename a variable
2023-09-18 01:45:53 +02:00
Edward
db6a9fcad9
Include a high-resolution option in the default resolution settings.
2023-09-18 01:15:22 +02:00
Isira Seneviratne
2c6f1ca166
Merge pull request #10248 from Isira-Seneviratne/NIO_downloads
...
Improve the download helpers using the Java 7 NIO API.
2023-09-17 21:09:02 +05:30
TacoTheDank
923d86365d
Update miscellaneous libraries
2023-09-17 15:43:43 +02:00
TobiGr
fd19e8e9f7
Replace RuntimeException with IOException
...
The RuntimeException was not explicitly declared and thus not caught at every call of this constructor. This change ensures that this possible exception is handled by the dedicated error handlers.
2023-09-17 15:31:19 +02:00