Vincent Tanumihardja
ae52f18561
Revert changes made to dev.
2023-09-21 16:01:07 +02:00
Vincent Tanumihardja
4332f062cf
Added delete xml method inside the yes dialogue.
2023-09-21 16:01:07 +02:00
Zhidong Piao
768defdab3
clear shared preference xmls
2023-09-21 16:01:07 +02:00
Vincent Tanumihardja
9ba69cc073
Changed alert dialogue.
2023-09-21 16:01:07 +02:00
Vincent Tanumihardja
e1524cb76a
Added alert dialogue and restarts the app when resetting settings.
2023-09-21 16:01:07 +02:00
Vincent Tanumihardja
93cef624c8
Added reset button but working as intended for theme.
2023-09-21 16:01:07 +02:00
Vincent Tanumihardja
3e40fe3ea9
Added reset button but slightly working as intended.
2023-09-21 16:01:07 +02:00
Vincent Tanumihardja
a570f70fce
Added reset button but not working as intended.
2023-09-21 16:01:07 +02:00
TobiGr
f4f2a8ed73
Improved accessibility of player interfaces
2023-09-21 12:20:00 +02:00
Stypox
f6714ac356
Merge pull request #10435 from TeamNewPipe/imp/codequality
...
Improve codequality
2023-09-20 21:24:44 +02:00
TobiGr
919c274820
Fix doc formatting
2023-09-20 19:44:23 +02:00
Isira Seneviratne
b99dcafba7
Switch to Files.createDirectories()
2023-09-20 19:44:23 +02:00
TobiGr
af715dd7ee
Remove useless override
2023-09-20 15:42:09 +02:00
TobiGr
fef0fa7b20
Reorder the modifiers to comply with the Java Language Specification.
2023-09-20 15:41:57 +02:00
TobiGr
ce58a60397
Add comments and annotations
2023-09-20 15:41:21 +02:00
TacoTheDank
2d5d209d6c
Replace MathUtils.clamp with Kotlin coerceIn
2023-09-19 16:32:37 -04:00
Stypox
f9e1da9c10
Merge pull request #10165 from TeamNewPipe/fix/media-format
...
Fix downloads of streams with missing MediaFormat
2023-09-19 15:54:12 +02:00
Stypox
4b7d1c4151
Simplify retrieveMediaFormatFromContentTypeHeader
...
Also check for nullity
2023-09-19 15:33:49 +02:00
TobiGr
4bbcfdc3e5
Fix three memory leaks
...
Add documentation to BaseFragment.initViews(View, Bundle) and BaseFragment.initListeners()
2023-09-19 00:13:16 +02:00
TobiGr
529bdb1aae
Fix previous ActionBar title visible for a few miliseconds when opening ChannelFragment
2023-09-18 23:22:32 +02:00
TobiGr
60a97b0486
Apply review
...
Co-Authored-By: Audric V <74829229+AudricV@users.noreply.github.com>
2023-09-18 23:22:32 +02:00
TobiGr
b134d75549
Deduplicate code to initialize ClickListeners on playlist controls
...
Add the separate utility class PlayButtonHelper to handle the initialization of the listeners.
The ClickListeners on playlist controls had different behaviours. This commit fixes that.
The commit also refactors the way how the app determines whether it is started for the first time. The previous version was not clean and recent in this PR caused it to fail.
2023-09-18 23:22:32 +02:00
AudricV
5af4db41ae
Hide the upload date element on the About tab
...
This empty element should be always hidden for this tab, as there is no upload
date available for channels.
2023-09-18 23:22:32 +02:00
AudricV
88419ec7b1
Always show the About tab and support having no description
2023-09-18 23:22:32 +02:00
TobiGr
43054e6d67
Extract actual feed loading code into separate method
...
Increase readability
2023-09-18 23:22:32 +02:00
TobiGr
2f65b4f823
Add missing @Override annotations to setupMetadata() implementations
2023-09-18 23:22:32 +02:00
Stypox
43097e4486
Update NewPipeExtractor and adapt imports
2023-09-18 23:22:32 +02:00
Stypox
5325226b33
Fix loading feed when a channel tab is empty
2023-09-18 23:22:32 +02:00
Stypox
9a70693152
Show snackbar with feed loading errors
2023-09-18 23:22:32 +02:00
Stypox
b26c5a7d5c
Improve placeholder channel banner handling
...
Now the placeholder gets hidden if there is no banner url or the user disabled images, to save space
2023-09-18 23:22:32 +02:00
Stypox
486664f293
Add avatar and bannner URLs to channel About tab
2023-09-18 23:22:32 +02:00
Stypox
5613a89099
Add space above channel description (About tab)
2023-09-18 23:22:32 +02:00
ThetaDev
36b11db357
feat: filter fetched channel tabs
2023-09-18 23:22:32 +02:00
ThetaDev
8f7cbc93ef
feat: add playlist controls to channel tab
2023-09-18 23:22:32 +02:00
Stypox
b900ddaadf
Fix some code smells
2023-09-18 23:22:32 +02:00
Stypox
fc402a8742
Fix channel tabs in main page setting title themselves
2023-09-18 23:22:32 +02:00
Stypox
aa4ec2f39e
Channels are now an Info
...
The previous "main" tab is now just a normal tab returned in getTabs().
Various part of the code that used to handle channels as ListInfo now either take the first (playable, i.e. with streams) tab (e.g. the ChannelTabPlayQueue), or take all of them combined (e.g. the feed).
2023-09-18 23:22:32 +02:00
ThetaDev
6c60ef9a9c
fix: notification menu option disappears when switching tabs
2023-09-18 23:22:32 +02:00
Stypox
559a1a46e1
Move channel header to collapsible app bar
2023-09-18 23:22:32 +02:00
ThetaDev
7a99f4910d
fix: NPE in ChannelFragment::onSaveInstanceState
2023-09-18 23:22:32 +02:00
ThetaDev
59426378f1
refactor: rename ChannelInfo to ChannelAbout
...
fix: localize about tab name
2023-09-18 23:22:32 +02:00
ThetaDev
397234a40f
cleanup: remove empty constructor from ChannelFragment
2023-09-18 23:22:31 +02:00
ThetaDev
13496f4533
refactor: common code from ChannelInfo/Description -> BaseInfoFragment
2023-09-18 23:22:31 +02:00
ThetaDev
773a6a8c7e
fix: channel tab title not being set
2023-09-18 23:22:31 +02:00
ThetaDev
72968fbefe
fix: ChannelFragment: save last tab
2023-09-18 23:22:31 +02:00
ThetaDev
cd797a6bef
refactor: adjustments to updated tab extractor API
2023-09-18 23:22:31 +02:00
ThetaDev
ca9102dd4c
fix: cache channel data
2023-09-18 23:22:31 +02:00
ThetaDev
bfce26fddc
fix: missing album tab key
2023-09-18 23:22:31 +02:00
ThetaDev
bf81bca9fd
feat: add album tab
2023-09-18 23:22:31 +02:00
ThetaDev
5ce45cd4f2
fix: remember selected channel tab on screen rotation
2023-09-18 23:22:31 +02:00