Sulkta-OSS/straw
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
11837 commits 4 branches 0 tags 89 MiB
Commit graph

86 commits

Author SHA1 Message Date
Mira
49aaaebd86 Feat: opus metadata encoding (#12974) 
Feat: Downloading: Add opus audio metadata tags for title, author, date, and a comment tag with the originating URL

This removes the DownloadManagerService.EXTRA_SOURCE field, which is always inferred from the StreamInfo.
 2026-01-03 11:55:59 +01:00
Tobi
0a89276b7a
Merge pull request #12575 from TransZAllen/dev 
[Bug] Fix missing subtitle text in manually downloaded *.SRT files. (issue #10030)
 2025-10-30 14:27:39 -07:00
TransZAllen
300afde83d
Update app/src/main/java/org/schabi/newpipe/streams/SrtFromTtmlWriter.java 
Co-authored-by: Tobi <TobiGr@users.noreply.github.com>
 2025-10-29 22:34:47 +08:00
TransZAllen
d311faea58 improve comments on TTML → SRT conversion 
- update class header with proper technical references and remove author tag.
- update comments of replacing NBSP('\u00A0'), especially adding examples
  of rendering incorrectly.
 2025-10-29 19:25:43 +08:00
TransZAllen
71aa6d52d3
Update app/src/main/java/org/schabi/newpipe/streams/SrtFromTtmlWriter.java 
Co-authored-by: Tobi <TobiGr@users.noreply.github.com>
 2025-10-28 17:39:04 +08:00
TransZAllen
3516667671 refactor(ttml): extract recursion into traverseChildNodesForNestedTags() 
- Extracted child-node traversal logic from `extractText()`
  into a helper method `traverseChildNodesForNestedTags()`.
- No functional change.
 2025-10-17 12:06:18 +08:00
TransZAllen
22ee01bcfb refactor(ttml): improve extractText() to preserve spaces and special characters 
- Replaced `text()` with `getWholeText()`:
  - avoids losing whitespaces at the beginning, end, or within the text;
  - avoids merging two or more consecutive spaces into a single space ' ';
  - avoids converting '\r', '\n', and '\r\n' within the text into a single space ' ';
  For subtitle conversion, the goal is to preserve every character exactly as intended by the subtitle author.
- Normalized tabs, line breaks, and other special characters for SRT-safe output.
- Added comprehensive unit tests in `SrtFromTtmlWriterTest.java`, including cases for simple and nested tags.
 2025-10-17 01:57:01 +08:00
TransZAllen
980e8f3951 [YouTube] *.srt numbering start at 1 instead of 0. (issue: https://github.com/TeamNewPipe/NewPipe/issues/12670) 
- The SubRip (.srt) specification requires subtitle numbering to begin from 1.
- Please refer to https://en.wikipedia.org/wiki/SubRip
- Previously numbering started from 0, which is accepted by most
  players (tested on mpv, VLC, MPlayer, Totem) but not strictly compliant.
 2025-09-29 18:04:35 +08:00
TobiGr
e1888ede87 Fix JDoc and apply suggestions 2025-08-27 10:38:13 +02:00
TransZAllen
2c35db7a07 [Bug] Fix missing subtitle text in manually downloaded *.SRT files. (issue #10030) 
- Previously, *.SRT files only contained timestamps and sequence numbers, without the actual text content.
- Added recursive text extraction to handle nested tags in TTML
  files.(e.g.: <span> tags)
 2025-08-27 14:03:42 +08:00
Stypox
df941670a8
Fix downloading/exporting when overwriting file would not truncate 2024-11-24 18:36:54 +01:00
Stypox
b8daf16b92
Update app/src/main/java/org/schabi/newpipe/streams/io/StoredDirectoryHelper.java 
Co-authored-by: Tobi <TobiGr@users.noreply.github.com>
 2024-04-23 18:39:56 +02:00
Stypox
caa3812e13
Ignore all errors when getting free storage space 
It's not a critical check that needs to be perfomed, so in case something does not work on some device/version, let's just ignore the error.
 2024-04-23 18:05:31 +02:00
Stypox
c3c39a7b24
Fix free storage space check for all APIs 
See https://stackoverflow.com/q/31171838
See https://pubs.opengroup.org/onlinepubs/9699919799/functions/fstatvfs.html
 2024-04-23 12:16:06 +02:00
CloudyRowly
2e318b8b03
Added "free memory" check before downloading [Android N / API 24+] (#10505) 
Added "free space" check before downloading eliminating bugs related to out-of-memory on Android N / API 24+
 2024-03-21 09:18:55 +01:00
TobiGr
779ea19222 Fix doc formatting 2023-09-20 19:44:23 +02:00
Isira Seneviratne
a1f2b7f8e8 Switch to Files.createDirectories() 2023-09-20 19:44:23 +02:00
TobiGr
f2c2f1735e Replace RuntimeException with IOException 
The RuntimeException was not explicitly declared and thus not caught at every call of this constructor. This change ensures that this possible exception is handled by the dedicated error handlers.
 2023-09-17 15:31:19 +02:00
TobiGr
4e41e12bd2 Small code and doc improvements 
Remove unnecessary else-branch and use Collections.isEmpty().
Add doc comment for splitFilename()
 2023-09-17 15:31:19 +02:00
Isira Seneviratne
6df808f266 Use Path in the download helper classes. 2023-09-17 14:50:26 +02:00
Isira Seneviratne
feb03f7e30 Use Math.floorDiv(). 2022-11-09 20:01:40 +05:30
Isira Seneviratne
fc46233baf Use toArray() with zero-length arrays. 2022-08-05 06:50:55 +05:30
litetex
8b209df253 Changed the code accordingly 
+ Removed some unused code
 2022-07-15 19:55:19 +02:00
litetex
99104fc11d
Clean up pre-Lollipop checks 2022-07-13 19:02:24 +02:00
Stypox
53f8415e9b
Use @SuppressWarnings for checkstyle suppressions & warnings 
It's better to use @SuppressWarnings instead of the suppressions file, so that the warning suppression is at the place where it acts.
 2022-03-18 23:57:11 +01:00
litetex
e806f8c4e6 Android 10+ only allows SAF -> Respect that in the dialog 2021-12-08 20:22:26 +01:00
litetex
744cfe5672 Removed unused import 2021-11-29 21:13:22 +01:00
litetex
17724a901c Removed annotations due to wrong warnings 2021-11-29 21:03:59 +01:00
litetex
b2323859e5 Refactoring + deduplicated code 2021-11-28 14:07:45 +01:00
litetex
f78983b16b Show an alert/dialog when no appropriate file-manager was found 2021-11-27 15:52:54 +01:00
Stypox
32dffb577c
Provide mime type to file picker to gray out unselectable files 2021-08-01 13:52:32 +02:00
Stypox
2aebf6ceaf
Add log when existsAsFile() is called on an invalid StoredFileHelper 2021-07-27 17:56:41 +02:00
Stypox
1822d21676
Fix NullPointerException when checking if storage exists 2021-07-27 11:36:14 +02:00
Stypox
2a99e0e435
Reimplement storing backup import/export path 
#6319 and #6402 were reverted before adding SAF changes, and have been readded at the end of SAF changes
 2021-06-08 10:41:24 +02:00
Stypox
21b8df0375
Check if file really exists before asking user to overwrite it 2021-06-08 10:40:45 +02:00
Stypox
b78ac7d2e9
Fix strange behaviour when app loses access to saf download folder 2021-06-08 10:40:45 +02:00
Stypox
114dc8ffa0
Pass mime type so that SAF treats file extension correctly 2021-06-08 10:40:45 +02:00
Stypox
eea43d5a73
Add comments to SharpStreams 2021-06-08 10:40:45 +02:00
wb9688
1164ea52f9
Move Stored(File|Directory)Helper into NewPipe 2021-06-08 10:40:44 +02:00
wb9688
0f75024e03
Support SAF properly 2021-06-08 10:40:44 +02:00
mhmdanas
eb1cefe2fa Make some minor changes 2021-05-15 18:48:16 +03:00
mhmdanas
ac86fe80c8 Fix typos 2020-12-07 13:35:37 +03:00
TobiGr
6f3dfad550 Fix Lint: Inconsistent line separators 2020-11-22 10:16:27 +01:00
TacoTheDank
0274cd6beb Lint: Inner class may be static 2020-11-18 18:02:33 -05:00
TacoTheDank
39e5d8ccc2 Lint: Make a bunch of stuff final 2020-11-18 17:50:00 -05:00
TacoTheDank
f86b40302d
Some general-purpose lint cleanup 2020-09-06 12:55:26 +02:00
wb9688
87228673b4 Use final where possible 2020-08-16 10:25:09 +02:00
Avently
d8f7db4715 Made checkStyle happy 2020-07-14 20:21:32 +03:00
Avently
d2aaa6f691 Merged the latest changes 2020-07-13 04:17:21 +03:00
kapodamy
8120b6aaaa checkstyle's amend 2020-07-05 23:55:40 -03:00