Commit graph

2356 commits

Author SHA1 Message Date
Stypox
d075cc424f Better handle url not supported in RouterActivity
Make sure the url not supported dialog is only shown when the url is really not supported, not on any ExtractionException
2021-03-12 23:21:54 +01:00
Stypox
ae9fa9be8e Improve email subject for error reporting 2021-03-12 23:21:54 +01:00
Stypox
6e665182d9 FeedFragment: fix view binding and show loading indicator correctly 2021-03-12 23:21:54 +01:00
Stypox
ef661dcaf4 Fix error panel and search fragment state saving 2021-03-12 23:21:54 +01:00
Stypox
c401e8ad76 Hide meta info panel in search when starting a new search 2021-03-12 23:21:54 +01:00
Stypox
47c3ebcd98 Fix views not scrollable when showing error panel 2021-03-12 23:21:54 +01:00
Stypox
22c92f1fb3 Completely remove return activity, now outdated 2021-03-12 23:21:54 +01:00
Stypox
9dc583da87 Optimize imports and solve checkstyle issues 2021-03-12 23:21:53 +01:00
Stypox
0ea6b4928c Add report/solve-recaptcha button in error panel
It will be shown even when nothing could be loaded not due to a network error, and the user can choose to ignore or report it.

Also improve error reporting arguments
Also completely refactor error activity
Also improve some code here and there
2021-03-12 23:21:49 +01:00
Stypox
bb398189d6 Move all error-related classes into error package 2021-03-07 17:49:28 +01:00
TiA4f8R
78e37c1705 Add different error messages for SoundCloud and YouTube unavailable contents
Add new error strings for the six new exceptions created in the extractor and catch these exceptions. Extractor is, of course, updated with this PR.
2021-03-07 15:33:25 +01:00
Isira Seneviratne
f0159edcc3 Fix crash when reordering channel groups. 2021-02-28 14:48:06 +05:30
XiangRongLin
7a9f95ce76 Merge pull request #5554 from karkaminski/enhancement/remove_resizing_text
removed resizing text from popup player
2021-02-15 16:15:27 +01:00
Tobi
4515c84ae4 Merge pull request #5543 from mhmdanas/remove-empty-string-concat
Remove unnecessary concat with empty string
2021-02-14 23:50:08 +01:00
Tobi
11fc691780 Merge pull request #5544 from mhmdanas/remove-content-uri
Remove License#contentUri
2021-02-14 23:49:07 +01:00
Tobi
79e28b7aa2 Merge pull request #5563 from Stypox/fix-tablayout-visibility
Fix tab layout visibility with age restricted videos
2021-02-14 21:32:10 +01:00
Stypox
aac5abedd0 Hide tab layout view pager on error 2021-02-14 13:40:17 +01:00
Stypox
e0ca7d6494 Fix tab layout visibility with age restricted videos
Add comments
2021-02-14 13:25:39 +01:00
karol
6de40e68a9 removed resizig text from popup player, as requested in #5514 2021-02-11 11:20:27 +01:00
mhmdanas
8ce697abec Remove License#contentUri
It seems to not be used anywhere.
2021-02-08 19:54:30 +03:00
mhmdanas
729e0b4f44 Remove unnecessary concat with empty string 2021-02-08 19:40:20 +03:00
Tobi
f106fc1245 Merge pull request #5464 from Stypox/fix-channel-subscribe-button
Fix channel subscribe button causing crash on closing
2021-02-03 09:24:26 +01:00
Tobi
31b0a93bcb Merge pull request #5474 from XiangRongLin/expires_header
Respect expires header when checking for new versions
2021-01-31 10:51:50 +01:00
TiA4f8R
6b5b6218c8 Fix some things in ShareUtils.java and do little improvements
Fix a bug in which NewPipe doesn't fall back to Google Play Store web url in InstallApp
Fusion getDefaultBrowserPackageName and getDefaultAppPackageName, rename openInDefaultApp to openAppChooser
Update some JavaDocs
2021-01-30 15:55:44 +01:00
XiangRongLin
0082c972cc Add comments explaining the expiry field
Co-authored-by: Tobias Groza <TobiGr@users.noreply.github.com>
2021-01-30 14:24:25 +01:00
XiangRongLin
9d72f029c2 Invert usage of manager.isExpired()
When it's expired it means, that the app should get the data. Meaning it should not abort prematurely by returning null.

Co-authored-by: Tobias Groza <TobiGr@users.noreply.github.com>
2021-01-30 09:32:17 +01:00
Stypox
e7226b4531 Set all default settings at the beginning 2021-01-28 18:28:29 +01:00
Stypox
3d6c34b896 Add Objects.requireNotNull to warning which is surely not null 2021-01-28 14:35:47 +01:00
Stypox
6d7e6d50b2 Remove useless getString for default setting value 2021-01-28 14:35:00 +01:00
Stypox
075e74073d Use PlayerHelper.retrieveResizeModeFromPrefs in Player 2021-01-28 14:33:50 +01:00
Stypox
e091a2ff36 Fix always minimizing to popup player 2021-01-28 14:33:12 +01:00
XiangRongLin
22dad3dc9d Respect expires header when checking for new version
It was called to many times and acted similar to a DOS attack.
2021-01-23 09:02:11 +01:00
Tobias Groza
37f0da0ebc Merge pull request #5458 from Stypox/fix-popup-x
Fix popup closing x button animation
2021-01-22 10:01:12 +01:00
Stypox
52ced8bf9c Fix channel subscribe button causing crash in main page tab
The binding was being set to null on onDestroyView() instead of in onDestroy()
2021-01-21 15:31:50 +01:00
Stypox
7bfb4104c8 Fix number being shown instead of corresponding string resorce in feed 2021-01-20 10:44:44 +01:00
Stypox
287324e455 Fix popup closing x button animation 2021-01-19 09:34:21 +01:00
TiA4f8R
26690d6233 Fix crash when no browser is present and use an ACTION_CHOOSER intent in the app update notification (#5429)
Fix crash when no browser is present and use an ACTION_CHOOSER intent for app update notification
Show a Toast when no app is present on user's device to open a content in an app and in a browser and use an ACTION_CHOOSER intent with the ACTION_VIEW intent put as an extra intent in the update notification.
2021-01-18 21:45:36 +01:00
XiangRongLin
99c3c49518 Merge pull request #5430 from Stypox/fix-feed
Fix reload feed button does nothing
2021-01-18 12:59:58 +01:00
Stypox
cd18def765 Refactor feed fragment 2021-01-18 11:43:05 +01:00
Stypox
f2789739e9 Fix reload feed button does nothing
initListeners was being called before the bindings were assigned, and therefore the click listener was never setup
2021-01-18 11:42:25 +01:00
XiangRongLin
f92e7ae794 Merge pull request #5442 from Stypox/fix-close-popup
Prevent IllegalArgumentException when closing popup
2021-01-18 09:39:02 +01:00
Stypox
1522eae016 Prevent IllegalArgumentException when closing popup 2021-01-18 08:27:49 +01:00
Stypox
64c7884850 Animate secondary controls toggle 2021-01-17 15:59:29 +01:00
Stypox
ff97338c11 Use KoreUtil function 2021-01-17 15:46:00 +01:00
Stypox
83b548da4b Hide tab layout in detail fragment when there is no space 2021-01-17 15:42:54 +01:00
Stypox
4c88c573ec Add content description to detail fragment tabs 2021-01-17 15:38:12 +01:00
Stypox
6d7ad35457 Add preference to hide description tab in video details 2021-01-17 15:36:42 +01:00
Stypox
923a68beaf Add icons to VideoDetailFragment tab layout for better accessibility 2021-01-17 15:34:24 +01:00
Stypox
8a4783f97b Move description to a tab alongside related streams and comments 2021-01-17 15:26:25 +01:00
Stypox
249ea33571 Add a secondary control panel to video detail fragment
It is shown when the user expands the description
It contains share, open in browser and play in kodi
2021-01-17 15:12:29 +01:00