Stypox
d5d4614df1
Merge pull request #7538 from ktprograms/fix-queue-channel-details-not-in-db
...
Load uploaderUrl when showing Channel Details from Play Queue
2022-01-26 09:58:32 +01:00
ktprograms
08cb92b40d
Load uploaderUrl when showing Channel Details from Play Queue
...
This checks if the uploaderUrl is in the database, if not it gets the
uploaderUrl and puts it in the database. This is similar to the fetching
of uploaderUrl when it doesn't exist done in #6919 .
Also use createNotification when error occurs in getStreamInfo.
2022-01-25 11:00:34 +08:00
TiA4f8R
e83d964fca
Fix first item played in playlists when switching player type or resolution
...
The issue was caused by an ExoPlayer change, which when setting a media source, resets the current playback position and the current window index by default.
Also set player recovery in more places to fix playback position not propely set in some cases after a player type switch.
2022-01-24 21:40:16 +01:00
litetex
52342d7358
Simplified toast showing behavior
...
after feedback from the review
2022-01-23 15:34:11 +01:00
litetex
34848c7cc3
Revert "Merge pull request #7568 from vhouriet/vhouriet_feature_already-playing-in-backgroud"
...
This reverts commit 4a12bedce8 , reversing
changes made to 4f06d935cd .
2022-01-23 15:34:11 +01:00
XiangRongLin
bc5ae5fc47
Make SearchHistoryEntry.kt fields nullable to match java version ( #7674 )
2022-01-21 16:01:11 +00:00
litetex
522cdfdb03
Merge pull request #7648 from mhmdanas/small-refactors
...
Fix false warning
2022-01-19 19:48:07 +01:00
XiangRongLin
6f9fd77015
Merge pull request #7668 from litetex/fix-video-reset-on-player-switch
...
Workaround: Set recovery before switching player
2022-01-19 16:45:10 +01:00
mhmdanas
f87a5ecead
Fix false warning
2022-01-18 07:40:59 +03:00
litetex
1f7c6dfdc9
Workaround: Set recovery before switching player
...
Quick fix
2022-01-17 20:52:07 +01:00
litetex
26fdba74c5
Merge pull request #7662 from TiA4f8R/fix-npe-share-button-playlists
...
Fix crash when sharing a playlist which is loading
2022-01-16 19:47:55 +01:00
XiangRongLin
7cfbd55c3a
Replace JUnit asserts with AssertJ in HistoryRecordManagerTest ( #7654 )
...
* Replace JUnit asserts with AssertJ in HistoryRecordManagerTest
They provide a wider range of assertions, which allow for more detailed error messages.
Also convert SearchHistoryEntry to kotlin data class for better error messages, since toString() is implemented.
Co-authored-by: Mohammed Anas <triallax@tutanota.com>
2022-01-16 09:10:45 +01:00
TiA4f8R
682877ea4f
Fix NullPointerException when sharing a playlist which is loading
...
Prevent a NullPointerException by adding a null check for currentInfo when sharing a playlist.
2022-01-15 21:19:04 +01:00
Stypox
08ef37691f
Merge pull request #7036 from Douile/fix/queue-metadata
...
Load full stream info when enqueuing a stream
2022-01-07 21:57:30 +01:00
Douile
0ee6530339
Remove unecessary interface InfoCallback
...
Co-authored-by: Stypox <stypox@pm.me>
Replace the unecessary callback interface InfoCallback in favour of the
standard type Consumer<SinglePlayQueue>
2022-01-03 17:52:27 +00:00
litetex
4ae2c43d16
Fixed search not accepting key input after closing player overlay ( #7607 )
...
* Fixed search not accepting key input after closing player overlay
* Made comments easier to understand
* More comments
2022-01-03 11:52:08 +01:00
litetex
4a12bedce8
Merge pull request #7568 from vhouriet/vhouriet_feature_already-playing-in-backgroud
...
Add Already playing in background toast
2021-12-31 14:54:05 +01:00
litetex
4f06d935cd
Merge pull request #7582 from Jaspann/sub-channel-tumbnail-view-fix
...
Fixes view of sub-channel icon when not in use
2021-12-31 14:52:32 +01:00
Jaspann
b7fb5081ba
Move sub icon visibility line
2021-12-28 15:54:36 -05:00
litetex
a87845e98e
Fixed usage of wrong string
2021-12-27 00:14:04 +01:00
litetex
1eb2688eea
Minified code
2021-12-26 23:57:54 +01:00
William Parker
3fc1e1cb1d
Fixed code styling
2021-12-26 00:12:48 -05:00
Jaspann
f15f2edc53
Fixes view of sub-channel icon when not in use
2021-12-25 18:10:05 -05:00
David Kramer
9095469b4e
Added ability to see pinned comment
2021-12-24 11:29:34 -06:00
Tobi
44af59cbe4
Merge pull request #7562 from TeamNewPipe/code-quality
...
Small improvements to code quality and readability
2021-12-23 23:54:29 +01:00
vhouriet
ee4678f788
Add Already playing in background toast
2021-12-23 22:12:38 +01:00
XiangRongLin
e86b68fe0f
Merge pull request #7556 from Jaspann/improve-hashtags
...
Fixes hashtags that use non-English characters.
2021-12-23 11:45:52 +01:00
Robin
f6f81be019
Merge pull request #7555 from litetex/remove-mediaparser
...
Remove/Revert MediaParser support (Android 11+) due to bugs
2021-12-22 17:32:28 +01:00
TobiGr
778f57b422
Small improvements to code quality and readability
...
Add annotations to methods and parameters.
Replace Jetbrains' @NotNull with Androidx' @NonNull annotatiation.
Make class variables static if possible.
Use constants for some Strings.
Simplify if conditions.
2021-12-21 20:55:41 +01:00
TobiGr
f484c67608
Introduce constants for some Strings that indicate no data in Tab class
2021-12-21 20:53:17 +01:00
TobiGr
c12552f7e7
Make PlayerHolder.bound private
2021-12-21 20:51:18 +01:00
Jaspann
23bd0842a9
Adds comment to HASHTAGS_PATTERN
2021-12-20 14:13:40 -05:00
Jaspann
4c3504c956
Allows multilingual support in hashtags
2021-12-19 20:33:55 -05:00
litetex
476ae318b7
Removed/Reverted MediaParser support (Android 11+) due to bugs
2021-12-19 20:16:10 +01:00
Robin
bfacb54792
Merge pull request #7451 from Cheechaii/respect-cutout-in-multiwindow
...
Respect cutouts when playing in MultiWindow
2021-12-19 13:23:28 +01:00
litetex
3ecaf66e1a
Merge pull request #7452 from litetex/show-alert-when-file-manager-not-found
...
Show an alert-dialog when no appropriate file-manager was found
2021-12-14 20:01:02 +01:00
litetex
960cd67321
Merge pull request #7482 from TeamNewPipe/unify-error-reporting
...
Unify error reporting and add error notification
2021-12-14 19:58:41 +01:00
XiangRongLin
561819e68c
Merge pull request #7491 from Stypox/fix-search-order
...
Fix order of local search results
2021-12-14 09:07:17 -05:00
litetex
36af68c75d
Merge pull request #7500 from TacoTheDank/bumpKtlint
...
Bump ktlint, Checkstyle, Java version
2021-12-12 15:07:24 +01:00
Douile
4b72ec36bc
Fix lambda code formatting
...
Co-authored-by: Stypox <stypox@pm.me>
2021-12-12 13:04:32 +00:00
Tom
77cb082f4b
Remove unecessary line
...
Co-authored-by: Stypox <stypox@pm.me>
2021-12-12 12:51:01 +00:00
Cheechaii
81b3b6de34
Respect cutouts when playing in MultiWindow
2021-12-09 20:58:05 +01:00
litetex
5ae1a58b31
Android 10+ only allows SAF -> Respect that in the dialog
2021-12-08 20:22:26 +01:00
Stypox
de83cff1e1
Fix order of local search results
2021-12-08 13:59:32 +01:00
Stypox
dad04f55c3
Add javadoc to ErrorUtil and ErrorActivity
2021-12-07 18:14:53 +01:00
TacoTheDank
9ccd358cb8
Update ktlint to 0.43.2
2021-12-04 21:22:29 -05:00
Robin
5baf6e8229
Disable media tunneling on Philips QM16XE
2021-12-04 22:23:09 +01:00
Stypox
86f8238cf1
Also show a toast on error notification
...
since the notification is silent, also show a toast, otherwise the user is confused
2021-12-04 10:50:27 +01:00
Stypox
8eec9b55bf
Remove PlayerErrorHandler and correctly set ErrorInfo msg
2021-12-04 10:36:36 +01:00
Stypox
9ac1add14c
Prevent exception from being serialized in ErrorInfo
...
The wrong @Decorator was put in the wrong place to mark the throwable fieldd as transient, now this is fixed and the exception is not serialized. So if a non-serializable throwable is passed, that's not an issue, since it's not going to be serialized. The need for EnsureExceptionSerializable is also gone.
2021-12-04 10:36:36 +01:00