Commit graph

46 commits

Author SHA1 Message Date
Stypox
12b25fcae1 Regression: fix icon size in main player 2020-05-29 15:32:44 +02:00
Stypox
f767116c25 Add shadow behind play icon in video detail fragment 2020-05-21 15:39:36 +02:00
Stypox
c80aba9a88 Use vector drawables instead of PNGs for material icons
For all manually-created images PNG have been kept.
- rename all icon attrs to have a `ic_` prefix
- always use `_24dp` icons, because there is no real difference, since they are vector drawables
- always use the original name found on material.io for icon drawables, as to not create confusion and possibly duplicates. Icon names can still be different from real drawable names, though I have made some of them compliant to this or maybe more meaningul.
- remove duplicate `getIconByAttr()` in ThemeHelper (use `resolveResourceIdFromAttr()`
- use standard icons for `expand_more` and `expand_less` instead of triangles
- use `play_button_outline` instead of custom PNG as play button in VideoDetailFragment (questionable, as there is no shadow anymore)
2020-05-21 15:39:35 +02:00
bopol
1151024ab4 subscribe button now match service's main color 2020-05-11 19:29:34 +02:00
Tobias Groza
bf564ae17c Merge pull request #3430 from Royosef/DisplayParentChannelDetails
Display parent channel details
2020-05-08 23:29:28 +02:00
wb9688
c9c1320da6 Don't show sub-channel thumbnail by default 2020-05-08 15:51:21 +02:00
Stypox
5ae0ffca23 In player hide kodi button if service unsupported 2020-05-07 21:11:34 +02:00
Roy Yosef
fb2c8bbd69 Fix PR review
Make all of the uploader section on stream page navigate to the channel page
Extract hard coded strings
Remove redundant spaces
Fix open streams from a channel
Rename "ParentChannel" to "SubChannel"
Config royosef:NewPipeExtractor in app/build.gradle
2020-05-07 20:40:17 +02:00
Roy Yosef
d13eba6d63 Add sub-channel details to video detail fragment 2020-05-07 20:39:32 +02:00
Alexander--
6bfd0bc144 Make channel info button focusable 2020-04-11 16:04:29 +06:59
Alexander--
6253ff6a36 Merge remote-tracking branch 'newpipe/dev' into rebase 2020-03-30 16:54:51 +06:59
bopol
b7c986b40b Change mute button color for more visibility 2020-03-21 16:58:53 +01:00
Alexander--
6f6d33153b Merge remote-tracking branch 'newpipe/dev' into rebase 2020-03-15 09:08:01 +06:59
bopol
35648c9315 fix captions overtaking mute button 2020-03-13 19:50:11 +01:00
Alexander--
a1d056bdb8 Merge remote-tracking branch 'newpipe/dev' into rebase 2020-03-12 04:48:37 +06:59
Alexander--
c5c7c41c8f Merge remote-tracking branch 'newpipe/dev' into rebase 2020-02-26 05:56:09 +06:59
karol
c793bc34c7 mute-button added to activity_main_player.xml's 2020-02-23 21:28:40 +01:00
bopol
9020ba6280 Multiple localization fixes
With the extractor PR, fixes title & description shown in the wrong language.
Fixed views / spectators counts possibly in the wrong language
Fixed live spectators not showing full count on detail page
Fixed LIVE shown on players, it shows translated instead

Fixed Videos string in search / three dots not available in Weblate
(because it was videos, but there already was a plural string named videos, in Weblate)

Subscriber count is always giving the short count.
We can't get exact number since this YouTube update: https://support.google.com/youtube/thread/6543166
But only short count (B, M, k), so showing full number, eg for 1.9M: 1,900,000, is wrong because the number could be 1,923,490 or 1,897,789…

Added a « sytem default » option to content language and country language selector.
It's the one selected by default (not en-GB anymore then), and correspond to the
language of the system / country of the system
By system I mean phone, tablet, TV…

Fixed russian showing - before time ago (eg 19hrs ago)
This is a workaround fix, I opened an issue on prettytime library repo.

Fixed russian plurals:
other was used instead of many for videos and subscribers

Fixed seek_duration english only
2020-02-15 12:40:23 +01:00
Alexander--
b1a2612958 Merge remote-tracking branch 'newpipe/dev' into rebase 2020-01-29 03:10:16 +06:59
Christophe
37d8cddf1f Add send to Kodi button to player next to share button 2020-01-27 10:27:24 +01:00
Alexander--
24d020d236 Disable touchScreenBlocksFocus on AppBarLayout
For some inexplicable reason this attribute got
enabled by default on Android 9, which effectively
prevents details screen from working
2019-12-01 12:41:11 +06:59
Alexander--
b952c8126d Add hints for focus transition from description 2019-12-01 12:41:11 +06:59
Alexander--
86fc9c0785 Special MovementMethod for video description
Video descriptions can be very long. Some of them are
basically walls of text with couple of lines at top or bottom.
They are also not scrolled within TextView itself, - instead
NewPipe expects user to scroll their containing ViewGroup.
This renders all builtin MovementMethod implementations useless.

This commit adds a new MovementMethod, that uses requestRectangleOnScreen
to intelligently re-position the TextView within it's scrollable container.
2019-12-01 12:41:11 +06:59
Alexander
ddc609e8d8 Support for seeking videos in directional navigation mode 2019-12-01 12:41:10 +06:59
Alexander
02c945bddd Make player screen controls into buttons
Buttons are more likely to have "correct" styling and are
focusable/clickable out of box
2019-12-01 12:41:10 +06:59
Alexander
bf21a7a1a3 Make description focusable, so TV users can scroll it 2019-12-01 12:41:10 +06:59
Alexander
2b8bd2c890 When child of CoordinatorLayout wants focus, show it!
The same logic is present in RecyclerView, ScrollView etc.
Android really should default to this behavior for all Views
with isScrollContainer = true
2019-12-01 12:41:10 +06:59
Alexander
5efd1a0897 MainPlayer: make title and subtitle non-focusable
Focus isn't needed for marquee, only selection
2019-12-01 12:41:10 +06:59
Robin
edd5ad2d13 Migrate to AndroidX 2019-10-04 14:59:08 +02:00
yausername
cc7e21a93b fix scrolling in video detail fragment. fixes #2627 2019-09-29 22:05:29 +05:30
Vasiliy
1c34e52829 Fix tablet ui 2019-05-06 19:16:39 +03:00
Vasiliy
36a34bd477 Merge branch 'dev' into playback_state_list 2019-04-27 17:37:43 +03:00
Vasiliy
dccb6f83e5 Fix scrolling details 2019-04-15 21:22:31 +03:00
Tobias Groza
a0690d3d2b Merge remote-tracking branch 'TeamNewPipe/dev' into close_button 2019-04-13 18:18:17 +02:00
Vasiliy
2e36b05a50 Implement playback state management 2019-04-13 13:34:36 +03:00
Stypox
b4e7830956 Add share button to main player layout
Placed under "more options"
2019-04-06 20:21:32 +02:00
Ritvik Saraf
a00cc3370d fixed scroll w/ comments and related streams disabled 2019-03-03 18:20:15 +05:30
Vasiliy
dab0036069 Merge branch 'dev' into close_button 2019-02-23 13:19:09 +02:00
Ritvik Saraf
7a11a72935 merged upstream/dev 2019-01-29 22:32:58 +05:30
kapodamy
d604b66012 add missing icons in bright theme
* missing white icons
* update attrs.xml and styles.xml
2019-01-22 18:53:30 -03:00
Vasily
d11f7414e4 Show close button when playing completed 2018-12-27 16:51:48 +02:00
Ritvik Saraf
fd4b046ab1 tablet ui support for comments 2018-12-09 03:21:55 +05:30
Vasily
78c59807bd Tablet UI in player 2018-08-31 17:30:06 +03:00
Vasily
9955c37e67 Always show description on tablets 2018-08-29 08:01:18 +03:00
Vasily
39f96c7c5c Fix crash on screen rotation 2018-08-22 10:29:37 +03:00
Vasily
a227cdf2e6 Video details tablet layout 2018-08-22 08:32:58 +03:00