Sulkta-OSS/straw
3
0
Fork 0
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity Actions
12003 commits 2 branches 0 tags 50 MiB
Commit graph

4424 commits

Author SHA1 Message Date
Clippy
ded310872b Merge pull request #13135 from dustdfg/player_loop_refactor 
Misc player loop/stream refactors
 2026-02-21 06:25:58 +00:00
Aayush Gupta
6516fb90a8 FocusOverlayView: Avoid accessing restricted API 
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
 2026-02-20 16:16:50 +08:00
Aayush Gupta
f80bd08dfb DownloadDialog: Avoid using restricted API for menuitem 
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
 2026-02-20 16:16:50 +08:00
Aayush Gupta
9f0b93fa1d DownloadRunnableFallback: Fix error with log tag being too long 
Abbreviate Download -> DL

Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
 2026-02-20 16:16:50 +08:00
Aayush Gupta
632b53e60c Use correct constant for hiding keyboard 
../../src/main/java/org/schabi/newpipe/local/subscription/dialog/FeedGroupDialog.kt:509: Must be one or more of: InputMethodManager.HIDE_IMPLICIT_ONLY, InputMethodManager.HIDE_NOT_ALWAYS

Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
 2026-02-20 16:16:50 +08:00
Aayush Gupta
13b1a42450 Use requireContext() instead of asserting non-null context 
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
 2026-02-20 16:16:50 +08:00
Aayush Gupta
bc462c05ab FinishedMIssionStore: Throw exception if column is missing 
../../src/main/java/us/shandian/giga/get/sqlite/FinishedMissionStore.java:105: Value must be ≥ 0 but getColumnIndex can be -1

Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
 2026-02-20 16:16:50 +08:00
Aayush Gupta
44b044f01d ReCaptchaActivity: Supress lint error for missing super call 
saveCookiesAndFinish method handles back navigation

Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
 2026-02-20 16:16:50 +08:00
Aayush Gupta
d35d5fa5d4 Add missing permission checks for notifications 
Notifications can be disabled manually even after permission has been granted once.
Always check if they are enabled before notifying the user.

Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
 2026-02-20 16:16:50 +08:00
Aayush Gupta
b69ab3abf6 Address non-final resource IDs warnings 
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
 2026-02-20 16:16:50 +08:00
Tobi
42e2a85fa0 Merge pull request #13247 from dustdfg/crashlog_fix 
Partially revert:  ErrorActivity: Kotlin-fy buildMarkdown method
 2026-02-19 00:37:56 -08:00
Tobi
e314afbad6 Merge pull request #13256 from pierreeurope/fix/ttml-postprocessing-error-reporting 
Fix subtitle post-processing error losing original exception
 2026-02-19 00:21:17 -08:00
Tobi
113345ef89 Merge pull request #13203 from dustdfg/video_detail_fragment_click_through 
VideoDetailFragment: Forcefully catch click events uncaught by children
 2026-02-18 23:45:35 -08:00
vt
e918cd3753 remove existing comment replies screens before adding new one 2026-02-19 12:07:22 +05:30
pierreeurope
c23b258a11 Fix subtitle post-processing error losing original exception 
Previously, TtmlConverter.process() caught all exceptions during TTML
to SRT conversion and returned opaque error codes (1 for IOException,
8 for other exceptions). These error codes were then wrapped by
Postprocessing.run() into a generic RuntimeException with the message
'post-processing algorithm returned N', losing the original exception
and its stack trace.

This made it impossible for users and developers to diagnose the root
cause of subtitle download failures, as reported in #13206.

Now, IOExceptions are re-thrown directly, and other exceptions are
wrapped in an IOException with the original exception as the cause.
This allows DownloadMission.doPostprocessing() to properly catch and
report the actual error, including the full stack trace in the crash
report.

Fixes #13206

Signed-off-by: pierreeurope <pierre.europe@pm.me>
 2026-02-16 12:46:30 +01:00
Yevhen Babiichuk (DustDFG)
b7c87aa5fb Partially revert: ErrorActivity: Kotlin-fy buildMarkdown method 
Partially reverts 389c1b0874
Fix the bug where collapse container for several crashlogs is created
when only one crash log present
 2026-02-13 13:43:54 +02:00
Yevhen Babiichuk (DustDFG)
c82bdb5846 ErrorActivity use normal \n instead of \\n in resource strings 2026-02-11 16:54:35 +02:00
Aayush Gupta
389c1b0874 ErrorActivity: Kotlin-fy buildMarkdown method 
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
 2026-02-11 21:40:02 +08:00
Aayush Gupta
1708e99e75 ErrorActivity: Catch exceptions not throwables 
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
 2026-02-11 21:40:02 +08:00
Aayush Gupta
4c8c110995 ErrorActivity: Use better variable names and encapsulation 
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
 2026-02-11 21:39:56 +08:00
Yevhen Babiichuk (DustDFG)
043e3b21c5 ErrorActivity convert to kotlin 
Co-authored-by: Aayush Gupta <aayushgupta219@protonmail.com>
 2026-02-11 18:31:12 +08:00
Yevhen Babiichuk (DustDFG)
c8b25a9f5a ErrorActivity small refactor 2026-02-11 18:31:12 +08:00
Yevhen Babiichuk (DustDFG)
1e8821d7f3 Misc loop/stream based player refactors 2026-02-10 11:26:23 +02:00
Yevhen Babiichuk (DustDFG)
10d4464b99 player/helper/PlayerHelper#getTimeString replace ints with longs 
Duration data in the player code incosnistently typed. Half code
uses ints and half uses longs. Recieve longs in this function to
allow both halfs of player code just use the function without
nasty long to int downcasting warnings/errors in code
 2026-02-10 11:24:25 +02:00
Aayush Gupta
99f26cc7ff Minor improvements 
- Use early return in case of nulls
- Use better variable names
- Remove non-required newlines, imports and add missing ones

Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
 2026-02-10 16:33:43 +08:00
Yevhen Babiichuk (DustDFG)
a379e46eb2 Convert newpipe/settings/export/PreferencesObjectInputStream to kotlin 2026-02-10 10:09:18 +02:00
Yevhen Babiichuk (DustDFG)
698f0ac61b Convert /newpipe/util/StreamTypeUtil to kotlin 2026-02-10 10:09:18 +02:00
Yevhen Babiichuk (DustDFG)
09e17d7540 Covert newpipe/util/DependentPreferenceHelper to kotlin 2026-02-10 10:09:18 +02:00
Yevhen Babiichuk (DustDFG)
2eb86d4f21 Convert newpipe/util/ServiceHelper to kotlin 2026-02-10 10:09:18 +02:00
Yevhen Babiichuk (DustDFG)
e4e3e8d351 Convert newpipe/util/NewPipeTextViewHelper to kotlin 2026-02-10 10:09:18 +02:00
Yevhen Babiichuk (DustDFG)
ba04b63832 Convert newpipe/ExitActivity to kotlin 2026-02-10 10:09:18 +02:00
Yevhen Babiichuk (DustDFG)
80ba2c49fa Convert newpipe/util/PeertubeHelper to kotlin 2026-02-10 09:51:14 +02:00
Yevhen Babiichuk (DustDFG)
3102c65f8a Convert newpipe/util/PlayButtonHelper to kotlin 2026-02-10 09:51:13 +02:00
Yevhen Babiichuk (DustDFG)
12b766f175 Uitilize kotlin elvis operator 2026-02-10 09:23:17 +02:00
Yevhen Babiichuk (DustDFG)
a54c55e7a4 SharedPreferences.edit applies changes automatically 2026-02-10 09:23:17 +02:00
Yevhen Babiichuk (DustDFG)
b6902e2587 Utilize kotlins ifEmpty 2026-02-10 09:23:17 +02:00
Yevhen Babiichuk (DustDFG)
62f224e01c Refactor settings/preferencesearch/PreferenceSearchItem#allRelevantSearchFields 
It doesn't need to return mutable list
 2026-02-10 09:23:17 +02:00
Yevhen Babiichuk (DustDFG)
25934e01eb Correct inverted check 
If performs action when value is true but check when false
Fix for 07e53a2d7a
 2026-02-09 14:31:56 +02:00
Aayush Gupta
c7c3520c63 Merge pull request #13137 from dustdfg/info_item_builder_dead 
Remove dead code from info_list/InfoItemBuilder
 2026-02-08 22:28:19 +08:00
Aayush Gupta
b5edd0a25e Merge pull request #13131 from dustdfg/tabs_json_helper_refactor 
TabsJsonHelper refactor
 2026-02-08 22:06:25 +08:00
Yevhen Babiichuk (DustDFG)
07e53a2d7a Replace Illegal{State,Argument} exceptions with more idiomatic kotlin code 2026-02-08 21:59:10 +08:00
Yevhen Babiichuk (DustDFG)
ed10aba501 VideoDetailFragment: Forcefully catch click events uncaught by children 
Because otherwise they will be caught by underlying view and
"click through" will happen. Workaround for #5600
 2026-02-06 19:03:01 +02:00
Tobi
e0892ca9df Merge pull request #13161 from jpds/outdated-subscription-shuffle 
FeedLoadManager: Shuffle the order outdated subscriptions are updated in
 2026-02-06 02:13:56 -08:00
AbsurdlyLongUsername
b5b6b6bdc4 Fix additional setRecovery from rebase errors 2026-02-05 11:17:30 +00:00
AbsurdlyLongUsername
bd255606d6 Add conditional guard to prevent useVideoAndSubtitles overwriting recovery position that was set in Player.handleIntent for RESUME_PLAYBACK when resuming playback 2026-02-05 05:05:41 +00:00
AbsurdlyLongUsername
b7d69682f7 Update useVideoAndSubtitles rename in comment 2026-02-05 05:05:40 +00:00
AbsurdlyLongUsername
10fc6bf2a3 Small refactor getPlayQueueFromCache 2026-02-05 05:05:40 +00:00
Yevhen Babiichuk (DustDFG)
5d681646e9 Refactor settings/tabs/TabsJsonHelper.java to use java streams 2026-02-02 23:59:01 +02:00
Jonathan Davies
6ccda31305 FeedLoadManager: Shuffle the order outdated subscriptions are updated in 2026-01-31 20:47:48 +00:00
Yevhen Babiichuk (DustDFG)
1905200e4d Remove dead code from info_list/InfoItemBuilder 
It no longer really builds any view and used only for stroing click
gesture callbacks. In the same way lik local/LocalItemBuilder does

Last usage of build functions: 93d12e5bf0
 2026-01-29 15:01:40 +02:00