Sulkta-OSS/straw
3
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions
10911 commits 1 branch 0 tags 50 MiB
Commit graph

9493 commits

Author SHA1 Message Date
Stypox
e97da723fc Add documentation and fix SonarCloud issue 2023-09-22 10:14:44 +02:00
Stypox
f7fe8adcdd Further improve image resolution strategy 
Now using multiple comparison steps instead of magic values
 2023-09-22 10:14:44 +02:00
Stypox
3f39514e3b Display all thumbnails in description tab 2023-09-22 10:14:44 +02:00
Stypox
4164bf36f6 Implement better image selection strategy 2023-09-22 10:14:44 +02:00
Stypox
a6a7c2271a Add image quality preference 2023-09-22 10:14:43 +02:00
Stypox
46109ff3b9 Support obtaining multiple images from the extractor 2023-09-22 09:57:33 +02:00
TobiGr
f4f2a8ed73 Improved accessibility of player interfaces 2023-09-21 12:20:00 +02:00
Stypox
f6714ac356 Merge pull request #10435 from TeamNewPipe/imp/codequality 
Improve codequality
 2023-09-20 21:24:44 +02:00
TobiGr
919c274820 Fix doc formatting 2023-09-20 19:44:23 +02:00
Isira Seneviratne
b99dcafba7 Switch to Files.createDirectories() 2023-09-20 19:44:23 +02:00
Tobi
9613396db0 Merge pull request #10244 from TacoTheDank/bumpMaterial 
Update Google Material library
 2023-09-20 18:19:53 +02:00
TobiGr
af715dd7ee Remove useless override 2023-09-20 15:42:09 +02:00
TobiGr
fef0fa7b20 Reorder the modifiers to comply with the Java Language Specification. 2023-09-20 15:41:57 +02:00
TobiGr
ce58a60397 Add comments and annotations 2023-09-20 15:41:21 +02:00
TacoTheDank
2d5d209d6c Replace MathUtils.clamp with Kotlin coerceIn 2023-09-19 16:32:37 -04:00
TacoTheDank
0983507f9a Update Google Material library 2023-09-19 16:30:09 -04:00
Stypox
f9e1da9c10 Merge pull request #10165 from TeamNewPipe/fix/media-format 
Fix downloads of streams with missing MediaFormat
 2023-09-19 15:54:12 +02:00
Stypox
4b7d1c4151 Simplify retrieveMediaFormatFromContentTypeHeader 
Also check for nullity
 2023-09-19 15:33:49 +02:00
TobiGr
4bbcfdc3e5 Fix three memory leaks 
Add documentation to BaseFragment.initViews(View, Bundle) and BaseFragment.initListeners()
 2023-09-19 00:13:16 +02:00
TobiGr
789764f3ea Remove unused content not supported TextView 2023-09-18 23:22:32 +02:00
TobiGr
529bdb1aae Fix previous ActionBar title visible for a few miliseconds when opening ChannelFragment 2023-09-18 23:22:32 +02:00
TobiGr
60a97b0486 Apply review 
Co-Authored-By:  Audric V <74829229+AudricV@users.noreply.github.com>
 2023-09-18 23:22:32 +02:00
TobiGr
b134d75549 Deduplicate code to initialize ClickListeners on playlist controls 
Add the separate utility class PlayButtonHelper to handle the initialization of the listeners.
The ClickListeners on playlist controls had different behaviours. This commit fixes that.

The commit also refactors the way how the app determines whether it is started for the first time. The previous version was not clean and recent in this PR caused it to fail.
 2023-09-18 23:22:32 +02:00
AudricV
8922bf76b5 Fix SubscriptionManagerTest tests 
The breakage of these tests is related to the channel tabs changes.

The testRememberRecentStreams test method has been removed, as it doesn't seem
to be relevant anymore to managing subscriptions.
 2023-09-18 23:22:32 +02:00
AudricV
0efc25423b Remove unneeded German translation 2023-09-18 23:22:32 +02:00
AudricV
5af4db41ae Hide the upload date element on the About tab 
This empty element should be always hidden for this tab, as there is no upload
date available for channels.
 2023-09-18 23:22:32 +02:00
AudricV
88419ec7b1 Always show the About tab and support having no description 2023-09-18 23:22:32 +02:00
TobiGr
43054e6d67 Extract actual feed loading code into separate method 
Increase readability
 2023-09-18 23:22:32 +02:00
TobiGr
2f65b4f823 Add missing @Override annotations to setupMetadata() implementations 2023-09-18 23:22:32 +02:00
Stypox
43097e4486 Update NewPipeExtractor and adapt imports 2023-09-18 23:22:32 +02:00
Stypox
7602473e53 Fix wrongly themed channel header 
Since it is embedded in the app bar and has red as background color, it should be themed in the same way as the toolbar.
 2023-09-18 23:22:32 +02:00
Stypox
e0e4265a19 Use consistent name for livestreams tab in settings keys 2023-09-18 23:22:32 +02:00
Stypox
5325226b33 Fix loading feed when a channel tab is empty 2023-09-18 23:22:32 +02:00
Stypox
9a70693152 Show snackbar with feed loading errors 2023-09-18 23:22:32 +02:00
Stypox
abbfbce6f9 Make channel banner placeholder match YouTube's size 
YouTube's "Desktop Max" thumbnails are 2560x423, while our previous placeholder banner was 2550x427. The extractor actually returns a lower resolution "Desktop Max" banner at 1060x175, but the ratio wrt 2560x423 is off by ~0.1%

The PNG was optimized with OptiPNG
 2023-09-18 23:22:32 +02:00
Stypox
b26c5a7d5c Improve placeholder channel banner handling 
Now the placeholder gets hidden if there is no banner url or the user disabled images, to save space
 2023-09-18 23:22:32 +02:00
Stypox
486664f293 Add avatar and bannner URLs to channel About tab 2023-09-18 23:22:32 +02:00
Stypox
5613a89099 Add space above channel description (About tab) 2023-09-18 23:22:32 +02:00
ThetaDev
a5298ce994 add channel banner placeholder 2023-09-18 23:22:32 +02:00
ThetaDev
36b11db357 feat: filter fetched channel tabs 2023-09-18 23:22:32 +02:00
ThetaDev
9661774a05 update NPE 2023-09-18 23:22:32 +02:00
ThetaDev
8f7cbc93ef feat: add playlist controls to channel tab 2023-09-18 23:22:32 +02:00
Stypox
b900ddaadf Fix some code smells 2023-09-18 23:22:32 +02:00
Stypox
fc402a8742 Fix channel tabs in main page setting title themselves 2023-09-18 23:22:32 +02:00
Stypox
aa4ec2f39e Channels are now an Info 
The previous "main" tab is now just a normal tab returned in getTabs().
Various part of the code that used to handle channels as ListInfo now either take the first (playable, i.e. with streams) tab (e.g. the ChannelTabPlayQueue), or take all of them combined (e.g. the feed).
 2023-09-18 23:22:32 +02:00
ThetaDev
a735063c5c fix: limit channel header height 2023-09-18 23:22:32 +02:00
ThetaDev
6c60ef9a9c fix: notification menu option disappears when switching tabs 2023-09-18 23:22:32 +02:00
Stypox
559a1a46e1 Move channel header to collapsible app bar 2023-09-18 23:22:32 +02:00
ThetaDev
7a99f4910d fix: NPE in ChannelFragment::onSaveInstanceState 2023-09-18 23:22:32 +02:00
ThetaDev
59426378f1 refactor: rename ChannelInfo to ChannelAbout 
fix: localize about tab name
 2023-09-18 23:22:32 +02:00