Commit graph

7798 commits

Author SHA1 Message Date
Stypox
ae3a9aecfb Sort tags in metadata section 2021-06-02 21:23:42 +02:00
Stypox
a98c0cc61d Use chips to show tags in metadata section
Clicking on chips opens the search fragment
Long clicking copies to clipboard
2021-06-02 16:15:02 +02:00
Stypox
aab4416947 Add button to allow selecting text in the description
Since now selection is disabled by default, this fixes #5453
2021-06-02 14:36:34 +02:00
Stypox
c49df41126 Allow copying metadata to clipboard 2021-06-02 14:19:25 +02:00
Stypox
4919161754 Show video metadata below the decription 2021-06-02 14:19:25 +02:00
Tobi
315f4ddcc4 Merge pull request #6410 from sauravrao637/6409
Fixed channel description textView
2021-06-01 11:02:47 +02:00
camo0112
3f00843299 fixed channel description textView 2021-06-01 10:43:57 +05:30
XiangRongLin
af92c3ed4f Annotate methode parameters as NonNull 2021-05-31 15:09:57 +02:00
XiangRongLin
c3d9c4bb3f Commit path immediately when import backup 2021-05-31 12:40:14 +02:00
XiangRongLin
a4bc61a7d0 Set ImportExportDataPath only on successful import
Also set the folder instead of the file itself as path
2021-05-31 12:38:21 +02:00
XiangRongLin
372d7a7832 Set ImportExportDataPath only on successful export 2021-05-31 12:36:21 +02:00
Tobi
efaea39ecc Merge pull request #6118 from sauravrao637/errorHandlingInSubcribe
Error handling in subscribe() in DownloadDialog
2021-05-29 11:30:36 +02:00
Tobi
6b70576d87 Merge pull request #6353 from Imericxu/fix-pasting-rich-text-in-search
Fix unwanted rich text formatting when pasting
2021-05-29 09:12:07 +02:00
Robin
32d4d2a432 Merge pull request #6387 from TeamNewPipe/empty_fragment_design
Fix empty fragment text not centered when text longer than one line
2021-05-28 17:48:38 +02:00
Tobi
7f3abfbd8c Merge pull request #6373 from TeamNewPipe/bandcamp-links
Improve Bandcamp intent filters
2021-05-28 15:17:00 +02:00
Tobi
5438064555 Merge pull request #6385 from sauravrao637/6371
Option for download is redundant and thus removed when linkType is CHANNEL or PLAYLIST
2021-05-28 14:23:04 +02:00
TobiGr
a79b3f83a6 Fix empty fragment text not centered when text longer than one line 2021-05-28 12:43:21 +02:00
camo0112
46e41ab913 Option for download is redundant and thus removed when linkType is CHANNEL or PLAYLIST 2021-05-28 03:38:53 +05:30
Zhiheng Xu
8b6da2f3ba Simplify code 2021-05-26 12:01:58 -04:00
Zhiheng Xu
0bb046dc7b Add comment 2021-05-26 12:01:58 -04:00
Zhiheng Xu
0e2f4f1922 Add formatting removal on paste for search
Closes #5912
2021-05-26 12:01:58 -04:00
Eric Xu
ad2e1dcf03 Add PlaylistTab.hashCode() matching equals 2021-05-26 12:01:30 -04:00
Eric Xu
9b4c7e6644 Refactor PlaylistTab.equals 2021-05-26 12:01:30 -04:00
Eric Xu
6ab457e51c Add ChannelTab.hashCode() matching equals 2021-05-26 12:01:30 -04:00
Eric Xu
346df8a36c Refactor ChannelTab.equals 2021-05-26 12:01:30 -04:00
Eric Xu
68f8c38445 Add KioskTab.hashCode() matching equals 2021-05-26 12:01:30 -04:00
Eric Xu
154e672c91 Refactor KioskTab.equals 2021-05-26 12:01:30 -04:00
Eric Xu
fe5e1df9c2 Add Tab.hashCode() to go with equals 2021-05-26 12:01:30 -04:00
Eric Xu
12425eaadc Refactor equals method 2021-05-26 12:01:30 -04:00
Fynn Godau
f0e110d832 [Bandcamp] Increase accuracy of intent filters 2021-05-26 15:11:38 +02:00
Fynn Godau
e89588b643 [Bandcamp] Handles links without /
Co-authored-by: yashpalgoyal1304 <yashpalgoyal1304@gmail.com>
2021-05-26 15:08:43 +02:00
Zhiheng Xu
fb8896e634 Remove Enclosed.class runner
Does not affect Gradle tests and only benefits IDE workflow
2021-05-24 13:03:52 -04:00
Zhiheng Xu
b8c6043569 Rewrite addToHistory test without using reflection 2021-05-24 12:20:19 -04:00
Zhiheng Xu
b153b5954d Rename mockPlayQueue(…) to makePlayQueue(…) 2021-05-24 12:20:19 -04:00
Zhiheng Xu
acbe0bfc94 Change shuffle() guard to check for size <= 2
After testing the app, I realized that shuffling a queue with size 2
does nothing
2021-05-24 12:20:19 -04:00
Zhiheng Xu
6da5d1585d Remove redundant clearing of list 2021-05-24 12:20:19 -04:00
Zhiheng Xu
e29058412e Refactor shuffle and update documentation
- Add early return for invalid sizes to shuffle

 - Rename variables to be more descriptive

 - Refactor moving list element, removing unnecessary operations

 - Unwrap if clause for adding to history because the condition is
   guaranteed by the guard clause

 - Inline the value 0 for the ReorderEvent

 - Update documentation to reflect new changes
2021-05-24 12:20:19 -04:00
Zhiheng Xu
0633e93dce Add test for setIndex 2021-05-24 12:20:19 -04:00
Zhiheng Xu
4952483013 Refactor static methods to package private
Stops Android Studio from "recognizing" them as tests
2021-05-24 12:20:19 -04:00
Eric Xu
3a8aa90c72 Rearrange fields
Final fields should be arranged first
2021-05-24 12:20:19 -04:00
Eric Xu
f9582a3d59 Test getItem(int) 2021-05-24 12:20:19 -04:00
Eric Xu
14e8fe51d0 Refactor making a PlayQueueItem to static method 2021-05-24 12:20:19 -04:00
Eric Xu
158791043e Resolve TODO in indexOf(...)
PlayQueueItem overrides equals and hashCode, so using indexOf is
perfectly fine.
2021-05-24 12:20:19 -04:00
Eric Xu
784c78c89e Rewrite setIndex(int) to pass unit tests
Original did not cover the case of when streams is empty and
documentation does not specify any input restrictions.

There's an ambiguity with broadcasting an event between the
documentation and the actual code (see TODO).
2021-05-24 12:20:19 -04:00
Eric Xu
9181930625 Test PlayQueue.setIndex(...) 2021-05-24 12:20:19 -04:00
Eric Xu
55da632641 Refactor assignments to field declaration
Assignments that don't require the constructor can be moved out.
2021-05-24 12:20:19 -04:00
Eric Xu
78ff6485a2 Add hashCode() to match equals(other) 2021-05-24 12:20:19 -04:00
Eric Xu
24b02a2dbd Test PlayQueue equals 2021-05-24 12:20:19 -04:00
Eric Xu
61e2ab4d80 Refactor streams to initialize with values 2021-05-24 12:20:19 -04:00
Eric Xu
8b2b3f8fe2 Refactor ArrayList fields to List 2021-05-24 12:20:19 -04:00