Commit graph

62 commits

Author SHA1 Message Date
Stypox
8cc890d799 Use @SuppressWarnings for checkstyle suppressions & warnings
It's better to use @SuppressWarnings instead of the suppressions file, so that the warning suppression is at the place where it acts.
2022-03-18 23:57:11 +01:00
litetex
5ae1a58b31 Android 10+ only allows SAF -> Respect that in the dialog 2021-12-08 20:22:26 +01:00
litetex
1ca53732b9 Removed unused import 2021-11-29 21:13:22 +01:00
litetex
6f554a1187 Removed annotations due to wrong warnings 2021-11-29 21:03:59 +01:00
litetex
625ffba8b7 Refactoring + deduplicated code 2021-11-28 14:07:45 +01:00
litetex
9285958b4f Show an alert/dialog when no appropriate file-manager was found 2021-11-27 15:52:54 +01:00
Stypox
6cf6a9faad Provide mime type to file picker to gray out unselectable files 2021-08-01 13:52:32 +02:00
Stypox
c558f90866 Add log when existsAsFile() is called on an invalid StoredFileHelper 2021-07-27 17:56:41 +02:00
Stypox
12e6ef4bce Fix NullPointerException when checking if storage exists 2021-07-27 11:36:14 +02:00
Stypox
2d92f18471 Reimplement storing backup import/export path
#6319 and #6402 were reverted before adding SAF changes, and have been readded at the end of SAF changes
2021-06-08 10:41:24 +02:00
Stypox
d920c7c1ea Check if file really exists before asking user to overwrite it 2021-06-08 10:40:45 +02:00
Stypox
c6ad9b8f66 Fix strange behaviour when app loses access to saf download folder 2021-06-08 10:40:45 +02:00
Stypox
3399ed2b30 Pass mime type so that SAF treats file extension correctly 2021-06-08 10:40:45 +02:00
Stypox
0c322e47cb Add comments to SharpStreams 2021-06-08 10:40:45 +02:00
wb9688
995264e5e2 Move Stored(File|Directory)Helper into NewPipe 2021-06-08 10:40:44 +02:00
wb9688
4e133a3599 Support SAF properly 2021-06-08 10:40:44 +02:00
mhmdanas
1f98ef54de Make some minor changes 2021-05-15 18:48:16 +03:00
mhmdanas
de2e4722ad Fix typos 2020-12-07 13:35:37 +03:00
TobiGr
40d32034dd Fix Lint: Inconsistent line separators 2020-11-22 10:16:27 +01:00
TacoTheDank
04f9272706 Lint: Inner class may be static 2020-11-18 18:02:33 -05:00
TacoTheDank
497e145c70 Lint: Make a bunch of stuff final 2020-11-18 17:50:00 -05:00
TacoTheDank
0ef2e07cf4 Some general-purpose lint cleanup 2020-09-06 12:55:26 +02:00
wb9688
25b56bf5e4 Use final where possible 2020-08-16 10:25:09 +02:00
Avently
a6894644d1 Made checkStyle happy 2020-07-14 20:21:32 +03:00
Avently
aef78ace88 Merged the latest changes 2020-07-13 04:17:21 +03:00
kapodamy
4515a5f4ed checkstyle's amend 2020-07-05 23:55:40 -03:00
kapodamy
39ee35c9d3 update WebMWriter.java 2020-07-03 20:51:45 -03:00
kapodamy
d8b2a5e51d Drop "writing/muxed by" metadata
* All muxers (mp4, webm and ogg) are affected
* solve some checkstyle's errors (building was blocked)

Mp4FromDashWriter:
* drop "writing application"
* drop "handler name"

OggFromWebMWriter:
* drop "writing application" for OPUS and VORBIS header

WebMWriter:
* Drop "Muxing application"
* Drop "Writing application"
2020-07-03 02:07:42 -03:00
Avently
60fd42dfa3 Changes for review 2020-06-27 06:25:50 +03:00
Roy Yosef
f2edfe399d Add sub-channel details to channel fragment 2020-05-07 20:39:32 +02:00
wb9688
205c5ff2ca Optimize imports 2020-05-01 20:13:01 +02:00
wb9688
213b0dc176 Suppress remaining Checkstyle errors 2020-04-09 17:24:43 +02:00
kapodamy
3be6402041 checkstyle
* drop unused methods
* split blobs
* make no final parameters
2020-04-08 12:08:01 -03:00
wb9688
4b196c6a8c Use Checkstyle for org.schabi.newpipe.streams as well 2020-04-02 16:48:57 +02:00
kapodamy
4c806c8ab9 code cleanup 2020-04-01 15:30:32 -03:00
kapodamy
0295a1fe49 misc changes
* read "SeekPreRoll" from the source track (if available)
* use the longest track duration as segment duration, instead of the video track duration
* do not hardcode the "Cue" reserved space behavior
* do not hardcode the "EBML Void" element, unreported issue. The size was not properly calculated
* rewrite the key-frame picking
* remove writeInt(), writeFloat() and writeShort() methods, use inline code
* set "SeekPreRoll" and "CodecDelays" values on output tracks (if available)
* rewrite the "Cluster" maker
* rewrite the code of how "Cluster" sizes are written

Fix encode() method (the reason of this commit/pull-request):
* Use the unsigned shift operator instead of dividing the value, due precession lost
2020-03-12 00:50:14 -03:00
kapodamy
25bed07c07 fixup for #3081
* dont write the "sbpg" box in video tracks
2020-02-20 13:20:20 -03:00
kapodamy
5e2aee6af2 Update DataReader.java
make rewind() method fully rewind the stream
2020-02-06 17:00:32 -03:00
kapodamy
10d6eab342 typo fixup 2020-01-29 16:06:40 -03:00
kapodamy
f7a6e6ff53 Merge branch 'dev' into m4a-stsc-stco 2020-01-29 15:58:20 -03:00
kapodamy
035bb657cd restore offset after writting lastest CTTS entries 2020-01-29 16:04:24 -03:00
kapodamy
3551e39d32 readability changes 2020-01-20 23:33:30 -03:00
kapodamy
27aa1abfdc 2 typo fixup
* add missing namespace of StandardCharsets
* use an unused constructor argument
2020-01-18 01:10:25 -03:00
kapodamy
0f5ce15280 StandardCharsets.UTF_8 instead of Charset.forName("utf-8") 2020-01-18 00:43:38 -03:00
kapodamy
21fbe869fc implement sgpd and sbgp boxes in audio tracks 2020-01-14 01:08:46 -03:00
kapodamy
e21e174fc0 decrease the size of samples per chunk 2020-01-14 00:04:53 -03:00
kapodamy
3877cec0ff ttml to srt conversion
rewrite SubtitleConverter (use JSoup library instead, remove unused methods)
2020-01-14 00:04:16 -03:00
Laurent Arnoud
b386ffeb4b Migrate annotation to androidx
release build is failing without this on android studio 3.5.3
2019-12-12 21:31:23 +01:00
kapodamy
104ec70755 remove netbeans editor-fold comments 2019-12-06 16:30:07 -03:00
kapodamy
fc4a892f45 code cleanup
* migrate few annotations to androidx
* mission recovery: better error handling (except StreamExtractor.getErrorMessage() method always returns an error)
* post-processing: more detailed progress

[file specific changes]

DownloadMission.java
* remove redundant/boilerplate code (again)
* make few variables volatile
* better file "length" approximation
* use "done" variable to count the amount of bytes downloaded (simplify percent calc in UI code)

Postprocessing.java
* if case of error use "ERROR_POSTPROCESSING" instead of "ERROR_UNKNOWN_EXCEPTION"
* simplify source stream init

DownloadManager.java
* move all "service message sending" code to DownloadMission
* remove not implemented method "notifyUserPendingDownloads()" also his unused strings

DownloadManagerService.java
* use START_STICKY instead of START_NOT_STICKY
* simplify addMissionEventListener()/removeMissionEventListener() methods (always are called from the main thread)

Deleter.java
* better method definition

MissionAdapter.java
* better method definition
* code cleanup
* the UI is now refreshed every 750ms
* simplify download progress calculation
* indicates if the download is actually recovering
* smooth download speed measure
* show estimated remain time

MainFragment.java:
* check if viewPager is null (issued by "Apply changes" feature of Android Studio)
2019-11-26 10:46:31 -03:00