straw/app/src
Stypox c0a007a023 Partial revert: fix VideoDetailFragment flickering
This partially reverts commit c31ae95f1f, which was needed to fix ghost notifications. There I broke the "cycle" causing the useless notifications to popup in 2 different places (see points 3 and 4 of the commit description).
However, breaking the cycle in point 4 ("`PlayerHolder::tryBindIfNeeded()` is now used to passively try to bind, instead of `PlayerHolder::startService()`" was not correct, for the following reason.
I assumed that `ACTION_PLAYER_STARTED` was used for notifying that the player was instantiated anew, while it actually is used to notify that something is now ready for use: it could be the player, but it could also just be that the bottom sheet view was just added and thus the VideoDetailFragment needs to start the player.
Therefore, when handling `ACTION_PLAYER_STARTED` it is correct to start the player service and not just try to bind to it.
The other point in which I broke the cycle (point 3) should still prevent ghost notifications, although I could not test.
2026-01-27 23:44:25 +01:00
..
androidTest/java/org/schabi/newpipe ktlint: Fix function-signature violations 2026-01-24 00:32:03 +08:00
debug Fix DebugApp doing unneeded AppWatcher.manualInstall 2023-07-14 18:32:04 +02:00
main Partial revert: fix VideoDetailFragment flickering 2026-01-27 23:44:25 +01:00
test ktlint: Fix standard_argument-list-wrapping violations 2026-01-24 00:31:44 +08:00