tests/fixtures/feed_lookup/past_stream.json still carried trackingParams
and clickTrackingParams (opaque YouTube tokens, 27 and 34 bytes once
base64-decoded; neither holds the capturing address as text or as four
bytes, checked with a planted control). They are removed; nothing reads
them. The three feed fixtures now each come out unchanged from the
README's scrub filter.
the_fixtures_carry_no_request_bound_data listed the twelve Live tab
fixtures by name and never looked at the three feed fixtures, and its
markers missed clickTrackingParams (the match was case-sensitive),
URL-encoded "ip%3D" and a bare IPv4 address. It now reads every JSON
file in both fixture directories from disk, checks that the walk found
five named files (so a moved directory cannot pass empty), and fails on
any "...TrackingParams" field, "ip%3D" or "ip%3d", and a dotted IPv4
address with every group at most 255. "20.772.51.34", a duration the
Indonesian fixture carries, is not taken for an address (772 > 255);
first_ipv4 has its own test. Run on the old past_stream.json, the guard
fails on trackingParams.
Correction to b1a0cf2: its message says tracking fields were removed
from the captures before saving. That was true of the Live tab fixtures
and not of past_stream.json, which kept both fields until this commit.
Cobb
a969254b09