Commit graph

5354 commits

Author SHA1 Message Date
Benoit Marty
5d086ad82d Fix moar ktlint issues 2024-01-11 10:02:10 +01:00
Benoit Marty
a831f05f6e Fix ktlint issues 2024-01-10 19:33:39 +01:00
Benoit Marty
140a11cf77 Ignore ktlint issue for this particular class. 2024-01-10 19:31:36 +01:00
Benoit Marty
64231044a7 Ignore ktlint issue for this particular object. 2024-01-10 19:31:36 +01:00
Benoit Marty
bac1e3902c Ignore ktlint issue for this particular val. 2024-01-10 19:31:36 +01:00
Benoit Marty
7572968e20 Ignore ktlint issue for this particular class. 2024-01-10 19:31:36 +01:00
Benoit Marty
99b38c8b0a Move doc to Kdoc and fix formatting issue. 2024-01-10 19:31:36 +01:00
Benoit Marty
e421dd2f14 Ktlint: disable rule standard:blank-line-before-declaration. 2024-01-10 19:31:36 +01:00
Benoit Marty
159b2f5c0a Ktlint: disable rule standard:function-naming for Composable function.
From https://github.com/pinterest/ktlint/issues/2259#issuecomment-1732333419
2024-01-10 19:31:36 +01:00
Benoit Marty
2e3b22009e Ktlint: disable rule standard:parameter-list-wrapping and standard:indent. 2024-01-10 19:31:36 +01:00
Benoit Marty
e9517f2bb3 Ktlint: disable rule standard:annotation. 2024-01-10 19:31:36 +01:00
Benoit Marty
b948a837ad Ktlint: disable rule standard:function-signature.
tom
2024-01-10 19:31:36 +01:00
Benoit Marty
3c3e85ed7c Ktlint: disable rule standard:multiline-expression-wrapping.
Need to also disable rule string-template-indent as a side effect.
2024-01-10 19:31:36 +01:00
Benoit Marty
dd919adb54 Update broken link 2024-01-10 19:31:36 +01:00
Benoit Marty
a28fd0c2e4 Upgrade ktlint to version 1.1.1.
Need to disable `ktlint_standard:trailing-comma-on-declaration-site` else got this error:
Skipping rule(s) which are depending on a rule which is not loaded. Please check if you need to add additional rule sets before creating an issue.
  - Rule with id 'RuleId(value=standard:trailing-comma-on-declaration-site)' requires rule with id 'RuleId(value=standard:wrapping)' to be loaded
2024-01-10 18:27:54 +01:00
renovate[bot]
c8bd362397
Update plugin ktlint to v12.1.0 (#2200)
* Update plugin ktlint to v12.1.0

* Run `./gradlew ktlintFormat` and fix some issues manually.

* Fix other issues reproted by Ktlint

* Limit false positives, KtLint removes unnecessary curly brace in String templates.

* Remove useless Unit

* Minor improvements over ktlint changes

* Restore `AlertDialogContent` behaviour

* Update screenshots

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Benoit Marty <benoit@matrix.org>
Co-authored-by: Jorge Martín <jorgem@element.io>
Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2024-01-10 16:22:24 +01:00
Benoit Marty
7e1866818e
Merge pull request #2198 from element-hq/renovate/io.nlopez.compose.rules-detekt-0.x
Update dependency io.nlopez.compose.rules:detekt to v0.3.9
2024-01-10 10:53:20 +01:00
Benoit Marty
628149ff62
Merge branch 'develop' into renovate/io.nlopez.compose.rules-detekt-0.x 2024-01-10 09:39:28 +01:00
Jorge Martin Espinosa
13e8e954d3
Improve rendering of voice messages in the timeline in large displays (#2199)
* Improve rendering of voice messages in the timeline in large displays

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2024-01-09 18:07:23 +01:00
Benoit Marty
2bdf2c0bbd
Merge pull request #1782 from element-hq/feature/bma/upgradeKover
Upgrade kover
2024-01-09 17:52:14 +01:00
Benoit Marty
45fd075752 Kover: we need Xml report as well. 2024-01-09 17:15:37 +01:00
Benoit Marty
b4481dc2a8 Fix the wrong coverage report
It wasn't taking into account any test result from the debug runs or screenshot tests

Co-authored-by: Jorge Martin Espinosa <jorgem@element.io>
2024-01-09 17:07:26 +01:00
renovate[bot]
ffb0fbdbdf
Update dependency io.nlopez.compose.rules:detekt to v0.3.9 2024-01-09 13:16:24 +00:00
Benoit Marty
07776f0104
Merge pull request #2196 from element-hq/fix/jme-crash-sending-picture-with-latest-posthog
Fix crash when sending image with latest posthog
2024-01-09 12:12:49 +01:00
Jorge Martin Espinosa
e8c6226586
Fix mention selector getting stuck when quickly deleting the prompt (#2195)
* Fix mention selector getting stuck when quickly deleting the prompt
2024-01-09 11:07:10 +00:00
Benoit Marty
80c69e7cf7 Migrate "When running on the CI, run only debug test variants".
Following notice here: https://github.com/Kotlin/kotlinx-kover/blob/v0.7.0/docs/gradle-plugin/migrations/migration-to-0.7.0.md#using-isdisabled-boolean-is-an-error-kover-test-task-config-was-removed
2024-01-09 11:04:28 +01:00
Benoit Marty
3b06576d21 Upgrade Kover to 0.7.5 2024-01-09 10:51:30 +01:00
Benoit Marty
5da6f21447 Remove empty module 2024-01-09 10:45:36 +01:00
Benoit Marty
54e499d0d0 Remove empty test module 2024-01-09 10:45:36 +01:00
Jorge Martín
e63eb3a7dc Fix crash when sending image with latest posthog 2024-01-08 16:12:22 +01:00
Benoit Marty
64b4a08b2f Let Renovate upgrade Kover again. 2024-01-08 14:17:37 +01:00
Jorge Martin Espinosa
afacef0146
Hide keyboard when tapping on a message in the timeline (#2187)
* Hide keyboard when tapping on a message in the timeline if it would result in navigating to another screen
2024-01-08 14:02:57 +01:00
renovate[bot]
8d7ada9e72
Update dependency io.mockk:mockk to v1.13.9 (#2185)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-01-08 11:19:15 +00:00
Benoit Marty
df368390f9
Merge pull request #2191 from element-hq/feature/bma/fixRRCrash
Do not use sublist as it crashes if `index > items.count()`.
2024-01-08 12:09:19 +01:00
Benoit Marty
b2cff05e5b
Merge pull request #2175 from element-hq/feature/bma/composeTest
Add first tests on compose click interaction.
2024-01-08 11:43:31 +01:00
Benoit Marty
0756a2d3e4 exclude items.count(), which is not a valid index for the list. 2024-01-08 11:41:29 +01:00
Benoit Marty
08d78740ab Do not use sublist as it crashes if index > items.count(). Using range is safer.
Fix https://github.com/element-hq/element-x-android-rageshakes/issues/1301
2024-01-08 11:26:50 +01:00
Benoit Marty
0a2df61354
Merge pull request #2189 from element-hq/renovate/com.posthog-posthog-android-3.x
Update dependency com.posthog:posthog-android to v3.1.0
2024-01-08 11:04:43 +01:00
Benoit Marty
2a6a3ded5e Iterate on EnsureCalledOnce devX 2024-01-08 10:07:48 +01:00
Benoit Marty
2c667a0dc0 Add run method to EnsureCalledOnce and EnsureCalledOnceWithParam to ensure that assertSuccess is always called. 2024-01-08 10:01:26 +01:00
renovate[bot]
74151f92dd
Update dependency com.posthog:posthog-android to v3.1.0 2024-01-08 08:58:09 +00:00
Benoit Marty
b08f34a295
Merge pull request #2177 from element-hq/renovate/anvil
Update anvil to v2.4.9-1-8
2024-01-08 09:55:54 +01:00
Benoit Marty
cd25990a41
Merge pull request #2131 from element-hq/feature/bma/sendImageFromKeyboard
Add support for sending images from the keyboard
2024-01-08 09:55:38 +01:00
Benoit Marty
dee8008917 Use string resource instead of hard-coded strings. 2024-01-08 09:50:08 +01:00
Benoit Marty
fdc3c9ff39 Improve assertion message. 2024-01-08 09:35:14 +01:00
Benoit Marty
56393288f9 Use Anvil for Kotlin 1.9 2024-01-08 09:29:04 +01:00
Benoit Marty
66bc3bf5c2
Merge pull request #2184 from element-hq/renovate/com.freeletics.flowredux-compose-1.x
Update dependency com.freeletics.flowredux:compose to v1.2.1
2024-01-08 09:27:09 +01:00
Benoit Marty
b6f88f9792
Merge branch 'develop' into feature/bma/sendImageFromKeyboard 2024-01-08 08:59:00 +01:00
Benoit Marty
ad9a174706
Merge pull request #2186 from element-hq/sync-localazy
Sync Strings
2024-01-08 08:58:15 +01:00
renovate[bot]
568385972b
Update plugin dependencycheck to v9.0.8 (#2179)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-01-08 08:51:51 +01:00