chore(deps): update rust crate serde_with to 3.21.0 [security] #16
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "renovate/crate-serde_with-vulnerability"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This PR contains the following updates:
3.7.0→3.21.0serde_with: KeyValueMap serialization panics on empty sequence or map entries
GHSA-7gcf-g7xr-8hxj
More information
Details
Summary
The public
KeyValueMapserializer assumes that each mapped element has at least one field or item to use as the map key, but it subtracts1from the caller-visible length before validating that assumption. An application that serializes attacker-controlled data through#[serde_as(as = "KeyValueMap<_>")]can be crashed by an empty inner sequence or map entry.Details
The affected public surface includes:
#[serde_as(as = "KeyValueMap<_>")]values throughserde_json::to_stringor any other Serde serializer`KeyValueMapconversions for sequence and map-backed entries`The root cause is: The
KeyValueMapserializer preallocatingVec::with_capacity(len - 1)orVec::with_capacity(len.unwrap_or(17) - 1)before checking that the element actually contains the required first key field or item.The vulnerable data/control flow is: attacker-controlled empty entry ->
serde_json::to_string->KeyValueMap<TAs>::serialize_as->SeqAsMapSerializer::{serialize_seq,serialize_map}->Vec::with_capacity(len - 1)orVec::with_capacity(len.unwrap_or(17) - 1)-> panicRelevant source locations:
serde_with/src/key_value_map.rs:590serde_with/src/key_value_map.rs:599serde_with/src/key_value_map.rs:613serde_with/src/key_value_map.rs:632serde_with/src/key_value_map.rs:648PoC
Impact
A local attacker who can trigger serialization of attacker-controlled data through
KeyValueMapcan terminate the process, causing a denial of service.Severity
CVSS:4.0/AV:L/AC:L/AT:N/PR:N/UI:N/VC:N/VI:N/VA:L/SC:N/SI:N/SA:NReferences
This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate.
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.Merge
Merge the changes and update on Forgejo.Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.