Commit graph

9706 commits

Author SHA1 Message Date
Stypox
b1690ca60d Update checkstyle to 10.0 and fix various related issues
- Put checkstyle files into checkstyle/ subfolder so that the gradle task does not implicitly depend on the whole project, fixing many warnings during build and possibly increasing build performance.
- Remove unused SuppressionXpathFilter from config file.
- Remove outdated suppressions from suppressions file.
2022-03-18 19:58:59 +01:00
litetex
37712a94cb Merge pull request #8067 from TacoTheDank/removeUnusedCode
Delete some unused code
2022-03-18 16:22:18 +01:00
TacoTheDank
3f9cd23979 Delete some unused code 2022-03-17 23:26:34 -04:00
Stypox
b3cb1bd43d Merge pull request #8011 from XiangRongLin/extract_view_listeners
Extract view click listeners from Player
2022-03-16 22:28:01 +01:00
litetex
463e37349a Fixed conflicts 2022-03-16 15:58:46 +01:00
litetex
405dc361e6 Better naming 2022-03-16 15:52:30 +01:00
litetex
71860f04eb Made `onClick` less (cognitive) complex 2022-03-16 15:52:30 +01:00
litetex
e005a3f590 Refactored code 2022-03-16 15:47:04 +01:00
XiangRongLin
fcc9e612f1 stupid checkstyle 2022-03-16 15:47:04 +01:00
XiangRongLin
419f334616 delete unused methods 2022-03-16 15:47:03 +01:00
XiangRongLin
8daf9527c9 Extract 2 view click listeners from Player 2022-03-16 15:47:03 +01:00
litetex
f70d87d0b1 Merge pull request #7981 from Stypox/sparse-items-deduplic
Deduplicate code for fetching stream info when sparse
2022-03-16 15:18:10 +01:00
litetex
70a5f1ab0e Merge pull request #7518 from mauriciocolli/remove-icon-duplicates
Remove icon duplicates and fix some theming issues
2022-03-15 21:51:04 +01:00
litetex
f4383ab195 Merge pull request #5878 from SpinHit/spinhit/addingDeleteConfirmation
Add a confirmation button when deleting all files in downloader
2022-03-15 21:49:46 +01:00
litetex
6d11142a52 Merge pull request #7978 from TacoTheDank/bumpSomeLibraries
Update some AndroidX libraries
2022-03-15 21:48:49 +01:00
litetex
ee55260c82 Merge pull request #7963 from Stypox/android-tv-player
Improve player UI and navigability for Android TV
2022-03-15 21:41:48 +01:00
litetex
3822d62c82 Merge branch 'dev' into bumpSomeLibraries 2022-03-15 21:34:41 +01:00
ktprograms
71289e6ea4 Implement appending queue to playlist in main player (#8008)
This also allows saving a remote playlist locally.

- Add an "Add to playlist" button to the queue menu in the Player.
- Move the appendAllToPlaylist functionality from PlayQueueActivity to
Player.

Fixes: #8004
2022-03-15 18:32:39 +01:00
Stypox
2ca158ee30 Fix comments and rearrange code 2022-03-15 15:20:25 +01:00
Stypox
e386add3e2 Merge pull request #7975 from TacoTheDank/updateCheckerRewrite
Migrate app update checker to AndroidX Work
2022-03-15 14:20:40 +01:00
Stypox
068b60f6e3 Merge pull request #7341 from ktprograms/external-play-hide-controls
Fix player controls not hiding if resumed from media button
2022-03-15 13:43:35 +01:00
TacoTheDank
bf800b348b Convert NewVersionWorker to Kotlin 2022-03-03 13:34:35 -05:00
TacoTheDank
9a8889c826 Migrate CheckForNewAppVersion to Worker (and rename it) 2022-03-03 13:26:57 -05:00
TacoTheDank
f2fec326e5 Migrate CheckForNewAppVersion to JobIntentService 2022-03-03 13:24:12 -05:00
TacoTheDank
15064830d2 Kotlin-ize ReleaseVersionUtil, merge with NewVersionManager 2022-03-03 13:21:50 -05:00
TacoTheDank
36c69cb3d6 Move utility methods out of CheckForNewAppVersion 2022-03-03 13:19:06 -05:00
Stypox
463c720a5c Deduplicate code for fetching stream info when sparse
Fixes #7941
2022-03-03 16:54:40 +01:00
Stypox
de989f9ffd Merge pull request #7976 from Stypox/remove-yes-string
Replace `R.string.yes` with `R.string.ok`
2022-03-03 10:17:54 +01:00
Stypox
54a8de8360 Restore handling SPACE as play-pause only in fullscreen
When not in fullscreen SPACE should be not handled by the player, and hence result in a scroll down
2022-03-03 10:14:58 +01:00
TacoTheDank
5c76c4a5fe Update some AndroidX libraries 2022-03-02 11:01:01 -05:00
Stypox
86fcceacab Fix playlist item not properly themed 2022-03-02 15:09:42 +01:00
Mauricio Colli
52d8f94213 Remove manual menu creation from some fragments
Doing this programmatically is just a no-go when themes are being set
in some other places (the toolbar is using a custom theme, in this
case), so, instead of hunting down the proper theme, just let the
system do its work.
2022-03-02 12:37:44 +01:00
Mauricio Colli
7baa4420ef Fix duplication of some icons used by the player 2022-03-02 12:33:01 +01:00
Mauricio Colli
a1b683c27f Add missing tint on drawer image view 2022-03-02 12:31:41 +01:00
Mauricio Colli
6812565581 Fix duplication of icon vectors 2022-03-02 12:31:41 +01:00
Stypox
cfc673d5a4 Replace R.string.yes with R.string.ok
Android doesn't use yes/no but ok/cancel usually, so this should be done here, too
2022-03-02 12:21:25 +01:00
Spinhit
c515fd1da0 Add confirmation button before deleting all files.
Co-authored-by: TiA4f8R <74829229+TiA4f8R@users.noreply.github.com>
2022-03-02 11:31:52 +01:00
Stypox
7376fb0c12 Merge pull request #7919 from karyogamy/progress-load-interval
Mitigating long buffering on initial video playback
2022-03-01 22:48:33 +01:00
litetex
7c8a301ffe Minor rework
* Moved settings to a better section
* Made string a bit shorter
2022-03-01 20:14:53 +01:00
karyogamy
4e3d71929d - added: variable load check interval for progressive stream.
- added: preferences to allow user setting of above.
2022-03-01 20:14:53 +01:00
Stypox
bcdf47177a Merge pull request #7728 from ktprograms/remember-playback-adjustment-step-size
Remember adjustment step size for playback controls (speed and pitch)
2022-03-01 10:54:47 +01:00
kt programs
0c5e3ae828 Remember adjustment step size for playback controls (speed and pitch)
- Add adjustment_step_key to settings_keys.xml to be used when
saving/loading the step size.
- Remove the global stepSize variable and the code that saves it to
outState/loads it from savedInstanceState because it's now saved to
Shared Preferences.
- Move initially setting step size to setupStepSizeSelector to be
consistent with the other view setup methods, using the value loaded
from Shared Preferences.
- Save the step size to Shared Preferences inside setStepSize.

Fixes: #7031
2022-03-01 16:27:20 +08:00
litetex
686750fc55 Merge pull request #7952 from TacoTheDank/bumpKotlin
Update Kotlin to 1.6.10
2022-02-28 19:42:38 +01:00
litetex
76b434a4ea Merge pull request #7954 from TacoTheDank/bumpInconsequential
Update ConstraintLayout, Room libraries
2022-02-28 19:42:19 +01:00
Stypox
6220315020 Fix player pop-ups not giving feedback on touch/focus 2022-02-27 18:49:16 +01:00
Stypox
75bdb2c89a Fix controls shown below queue/segments list when using DPAD
Also invert if
2022-02-27 18:49:16 +01:00
Stypox
797140329b Fix player queue/segments list buttons not focusable with DPAD
Now the in-player play queue and the segments list are closeable
2022-02-27 18:49:16 +01:00
Stypox
175aa0d6b1 Merge pull request #7894 from Stypox/delete-large-land-player
Remove large-land player layout: not actually used
2022-02-27 18:46:51 +01:00
litetex
f25ca020b9 Merge pull request #7947 from TacoTheDank/bumpPluginsNGradle
Update AGP and Gradle
2022-02-27 17:48:22 +01:00
Stypox
1923187d4c Merge pull request #7565 from haklc/dev
Change pitch by semitones
2022-02-27 09:58:38 +01:00