Sulkta-OSS/straw
3
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions
10482 commits 1 branch 0 tags 50 MiB
Commit graph

10482 commits

This branch
This branch
All branches
Author SHA1 Message Date
Stypox
efaf785972 Merge pull request #9445 from Jared234/9122_remove_watched_bug 
Fixed a bug that incorrectly removed videos from a playlist when using the "Remove Viewed" dialog
 2023-01-12 23:45:48 +01:00
Jared Fantaye
71be67f17d Fixed the "Remove Watched" bug 
Reverted changes and fixed bug in a different way
 2023-01-12 23:44:26 +01:00
Stypox
52be821088 Merge pull request #9523 from Jared234/9468_permanently_set_thumbnail 
Allow the user to permanently set a thumbnail
 2023-01-12 23:27:50 +01:00
Stypox
55726df2c4 Merge pull request #8886 from Isira-Seneviratne/Remove_Runnable_variables 
Remove Runnable variables for Handlers.
 2023-01-12 15:34:12 +01:00
Isira Seneviratne
f8e6962849 Remove Runnable variables for Handlers. 2023-01-12 15:30:19 +01:00
Stypox
48d181d9ae Merge pull request #9619 from Redirion/avoidreflectionifpossible 
Check availability of Samsung DeX only on Samsung devices
 2023-01-12 12:06:19 +01:00
Stypox
9bf4de43ca Merge pull request #9653 from petlyh/fix-popup-crash 
Ask for permission when enqueuing in a popup
 2023-01-12 11:24:21 +01:00
Stypox
62fdd08ccf Merge pull request #9499 from pratyaksh1610/branch-9466 
Added Language suffix for subtitle downloads
 2023-01-11 19:46:51 +01:00
Stypox
db05801c5b UX improvements: keep user edits & do not reset cursor 2023-01-11 19:45:55 +01:00
Stypox
b6b09b68af Actually there is no need to use flatMap 
`null` values returned in the lambda are converted to empty `Optional`s in the `map` method: https://developer.android.com/reference/java/util/Optional#map(java.util.function.Function%3C?%20super%20T,%20?%20extends%20U%3E)
 2023-01-11 15:26:46 +01:00
Stypox
0f0a1d36d8 Merge pull request #9135 from devlearner/routeractivity-screen-rotate 
Improve screen rotation handling in Open action menu
 2023-01-11 15:20:47 +01:00
Stypox
3dde6c70bc Use Optional for simpler code 2023-01-11 15:14:18 +01:00
devlearner
345ee656cf Improve showing of toast 
We provide visual feedback via a toast to the user that, well, they're supposed to wait; but with the benefit of the cache openAddToPlaylistDialog() may return (almost) immediately, which would render the toast otiose (if not a bit confusing). This commit improves that by cancelling the toast once the wait's over

... (by 'abusing' RxJava's ambWith();
ref on compose() and Transformer: https://blog.danlew.net/2015/03/02/dont-break-the-chain/
and for me, first time laying my hands at RxJava so kindly bear with me; open for suggestions)
 2023-01-11 14:53:48 +01:00
devlearner
a6381ce3b3 Utilize Lifecycle observer 
I thought it would have required an extra dependency; apparently that doesn't seem to be the case...
 2023-01-11 14:53:48 +01:00
devlearner
cedc02bd73 Oops, added back missing return; 2023-01-11 14:53:48 +01:00
devlearner
ebf314b7ab Fix Sonar reported code smell 2023-01-11 14:53:48 +01:00
devlearner
9a334187c6 Skip REORDER_TO_FRONT trick which doesn't seem to work on newer Androids 
probably due to background restrictions on Android 10+
 2023-01-11 14:53:48 +01:00
devlearner
06351cc12c Utilize a retained fragment to safekeep network requests in flight 
pending result for openAddToPlaylistDialog() and openDownloadDialog()
Despite marked deprecated, setRetainInstance(true) is probably our best bet (since a ViewModel is probably too overkill for our present purpose)
 2023-01-11 14:53:48 +01:00
devlearner
fcd556e555 Improve (un)registering FragmentLifecycleCallbacks 
to avoid adding it multiple times and ensure proper cleanup
 2023-01-11 14:53:48 +01:00
devlearner
c9ff6b1e56 Address LayoutParams.FLAG_NOT_TOUCHABLE restriction on Andriod 12+ 2023-01-11 14:53:48 +01:00
devlearner
e7a61358f7 Ensure our transparent activity doesn't block touch events to underlying windows 
so we won't hold up UI while fetching media info for Add to Playlist or Download actions
lest user might think it freezes when in fact a network request is underway
 2023-01-11 14:53:48 +01:00
devlearner
2612c1cdf3 Also show toast in openDownloadDialog() 
and lengthened a bit to inform user to wait...
 2023-01-11 14:53:48 +01:00
devlearner
0d430f99e6 Try to amicably handle DialogFragment in FragmentManager when recreated from orientation change 
- Handle finish() call instead of passing around callbacks to setOnDismissListener()
- Don't start over again if returning to DialogFragment before orientation change
 2023-01-11 14:53:48 +01:00
devlearner
c173e04aa4 Don't finish() to allow recreate 
when orientation change is on foot
 2023-01-11 14:53:48 +01:00
devlearner
94cc1f2982 Set up theme/locale before super.create() 
This seems to solve a bug where the Open action menu dialog does not appear the first time on cold start on older Android (8.0).
This is also the order of things in MainActivity and probably good practice.
 2023-01-11 14:53:48 +01:00
Stypox
b17415a88e Merge pull request #9285 from Isira-Seneviratne/Optional_cleanup 
Clean up Optional-related code.
 2023-01-11 14:52:25 +01:00
Stypox
8ea120865c Use Optional.map correctly and other improvements 2023-01-11 14:47:53 +01:00
petlyh
c45279d38a Ask for permission when enqueuing in a popup 2023-01-10 14:16:19 +01:00
Jared Fantaye
8016140124 Removed the "Unset Thumbnail" item if you can't use this feature 2023-01-04 16:21:16 +01:00
Isira Seneviratne
245406e967 Apply code review suggestions. 2023-01-04 06:10:14 +05:30
Isira Seneviratne
af75d5a055 Use Optional chaining. 2023-01-04 05:16:21 +05:30
Isira Seneviratne
cae0eda806 Remove SimplifyOptionalCallChains. 2023-01-04 05:16:21 +05:30
Robin
f601e09592 Samsung DeX should only be checked on Samsung devices 
Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
 2023-01-03 15:12:02 +01:00
pratyaksh1610
229157583a move string to donottranslate.xml and fix nits 2023-01-03 14:07:28 +05:30
Stypox
ae0f0b94a3 Merge pull request #9553 from Redirion/exo182 
Update ExoPlayer to 2.18.2
 2023-01-02 18:21:53 +01:00
Stypox
5877ca6cc0 Merge pull request #8769 from Isira-Seneviratne/New_Utils_methods 
Use new NPE UTF8 Utils methods
 2023-01-02 17:59:26 +01:00
Stypox
fc5a5c4e1c Merge pull request #9562 from bravenewpipe/use-videostream-for-audio-only-background-playback 
Support audio only background for services only supporting video streams
 2023-01-02 17:51:10 +01:00
Stypox
5390b7b0ab Merge pull request #8841 from Isira-Seneviratne/Notification_mode_ListAdapter 
Use ListAdapter in NotificationModeConfigAdapter.
 2023-01-02 14:47:25 +01:00
Stypox
fb623e4e2c Simplify disposables handling in notification mode settings 2023-01-02 14:45:11 +01:00
pratyaksh1610
6ccf2cbad0 updated caption file name and clean code 2023-01-02 16:23:45 +05:30
Robin
b5c19b1d59 Merge branch 'TeamNewPipe:dev' into exo182 2023-01-02 10:35:20 +01:00
Isira Seneviratne
c529738bd2 Use new NewPipe Extractor Utils methods. 2023-01-02 07:03:18 +05:30
evermind
1cf3b9fa23 set 'playback in background button' visible if there are videostreams 2023-01-01 21:55:03 +01:00
Stypox
b9543ac79b Merge pull request #9568 from pratyaksh1610/branch-add-play-all-icon 
Added icon for "Play All"
 2023-01-01 18:03:42 +01:00
Stypox
d3f62ab292 Merge pull request #9520 from Isira-Seneviratne/Update_RxJava 
Update RxJava to 3.1.5.
 2023-01-01 12:52:06 +01:00
Stypox
0de5cf5ce3 Update rxandroid from 3.0.0 to 3.0.2 2023-01-01 12:46:56 +01:00
Stypox
720b194bd5 Merge pull request #9521 from pratyaksh1610/branch-9518 
Fixes #9518: Crash fix when click "Add to playlist" while the current list is still loading
 2022-12-31 23:31:58 +01:00
Stypox
2ecd0f437b Remove playlist details toasts 2022-12-31 23:30:17 +01:00
Stypox
adc8f516e2 Merge pull request #9502 from Jared234/8585_download_in_queue 
Added option to download items in the queue
 2022-12-31 19:34:07 +01:00
Stypox
b59b2a6517 Use correct fragment manager for download dialog 
Tapping download on the long-press menu of queue items when the queue is shown inside the player would crash otherwise
 2022-12-31 19:31:24 +01:00