Cobb
ad4341543c
Comments named on-screen buttons by a glyph; they now say the button's
name: the fullscreen button (5 places), the down-arrow overlay button,
the close button on the minibar (4 places, plus "the X button" for the
downloads row), the background-audio (headphones) button and the
picture-in-picture overlay button. The changelog in ProjectConfig.kt
is history and keeps its meaning.
Also: no crab in hello_from_rust's returned text (nothing in the app
calls it), plain names in the GitHub issue-template links ("Question",
"Matrix chat", "IRC chat"), "Warning:" in place of the warning sign in
the pull request template, and no kaomoji at the end of the en-US store
changelog 70.
Not touched: punctuation (em dashes, arrows in prose, bullets, the
folder trees), the multiplication sign where it means "times", the
copyright sign in the vendored gradlew, and the symbols straw draws on
screen, which the next commit replaces with Material icons.
36 lines
2.3 KiB
Markdown
36 lines
2.3 KiB
Markdown
<!-- Hey there. Thank you so much for improving NewPipe, and filling out the details. Having roughly the same layout helps everyone considerably :)-->
|
|
|
|
#### What is it?
|
|
- [ ] Bugfix (user facing)
|
|
- [ ] Feature (user facing). **Warning: your PR must target the [`refactor`](https://github.com/TeamNewPipe/NewPipe/tree/refactor) branch**
|
|
- [ ] Codebase improvement (dev facing)
|
|
- [ ] Meta improvement to the project (dev facing)
|
|
|
|
#### Description of the changes in your PR
|
|
<!-- While bullet points are the norm in this section, feel free to write free-form text instead of a list -->
|
|
- record videos
|
|
- create clones
|
|
- take over the world
|
|
|
|
#### Before/After Screenshots/Screen Record
|
|
<!-- If your PR changes the app's UI in any way, please include screenshots or a video showing exactly what changed, so that developers and users can pinpoint it easily. Delete this if it doesn't apply to your PR.-->
|
|
- Before:
|
|
- After:
|
|
|
|
#### Fixes the following issue(s)
|
|
<!-- Prefix issues with "Fixes" so that GitHub closes them when the PR is merged (note that each "Fixes #" should be in its own item). Also add any other relevant links. -->
|
|
- Fixes #
|
|
|
|
#### Relies on the following changes
|
|
<!-- Delete this if it doesn't apply to your PR. -->
|
|
-
|
|
|
|
#### APK testing
|
|
<!-- Use a new, meaningfully named branch. The name is used as a suffix for the app ID to allow installing and testing multiple versions of NewPipe, e.g. "commentfix", if your PR implements a bugfix for comments. (No names like "patch-0" and "feature-1".) -->
|
|
<!-- Remove the following line if you directly link the APK created by the CI pipeline. Directly linking is preferred if you need to let users test.-->
|
|
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration [on this wiki page](https://github.com/TeamNewPipe/NewPipe/wiki/Download-APK-for-PR).
|
|
|
|
#### Due diligence
|
|
- [ ] I read the [contribution guidelines](https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md).
|
|
- [ ] The proposed changes follow the [AI policy](https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md#ai-policy).
|
|
- [ ] I tested the changes using an emulator or a physical device.
|