Commit graph

4456 commits

Author SHA1 Message Date
Marco Romano
26eecb33dd
Voice messages: Don't crash if mxc uri is invalid (#1756)
<!-- Please read [CONTRIBUTING.md](https://github.com/vector-im/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
 
## Type of change

- [ ] Feature
- [x] Bugfix
- [ ] Technical
- [ ] Other :

## Content

Code now checks whether the mx uri is invalid and handles the error condition properly.

## Motivation and context

https://github.com/vector-im/element-x-android/pull/1748#discussion_r1384557443

## Screenshots / GIFs

<!--
We have screenshot tests in the project, so attaching screenshots to a PR is not mandatory, as far as there
is a Composable Preview covering the changes. In this case, the change will appear in the file diff.
Note that all the UI composables should be covered by a Composable Preview.

Providing a video of the change is still very useful for the reviewer and for the history of the project.

You can use a table like this to show screenshots comparison.
Uncomment this markdown table below and edit the last line `|||`:
|copy screenshot of before here|copy screenshot of after here|

|Before|After|
|-|-|
|||
 -->

## Tests

<!-- Explain how you tested your development -->

- Step 1
- Step 2
- Step ...

## Tested devices

- [ ] Physical
- [ ] Emulator
- OS version(s):

## Checklist

<!-- Depending on the Pull Request content, it can be acceptable if some of the following checkboxes stay unchecked. -->

- [ ] Changes have been tested on an Android device or Android emulator with API 23
- [ ] UI change has been tested on both light and dark themes
- [ ] Accessibility has been taken into account. See https://github.com/vector-im/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
- [ ] Pull request is based on the develop branch
- [ ] Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-x-android/blob/develop/CONTRIBUTING.md#changelog
- [ ] Pull request includes screenshots or videos if containing UI changes
- [ ] Pull request includes a [sign off](https://matrix-org.github.io/synapse/latest/development/contributing_guide.html#sign-off)
- [ ] You've made a self review of your PR
2023-11-08 07:46:00 +01:00
ganfra
d4f6a1814a
Merge pull request #1761 from vector-im/renovate/org.maplibre.gl-android-sdk-ktx-v7-2.x
Update dependency org.maplibre.gl:android-sdk-ktx-v7 to v2.0.2
2023-11-07 21:13:22 +01:00
renovate[bot]
e2237e0779
Update dependency org.maplibre.gl:android-sdk-ktx-v7 to v2.0.2 2023-11-07 18:06:41 +00:00
Jorge Martin Espinosa
26c28ff972
Message composer isn't resized when changing the replied to message (#1750) 2023-11-07 16:59:58 +01:00
Jorge Martin Espinosa
1fe45cde18
Improve confusing text in the 'ready to start verification' screen (#1751)
* Improve confusing text in the 'ready to start verification' screen

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2023-11-07 14:33:26 +01:00
Benoit Marty
2de508c6d5
Merge pull request #1737 from vector-im/feature/bma/improvePages
Create UserStoryFlowPage
2023-11-07 14:30:38 +01:00
Jorge Martin Espinosa
52c9565ac8
Fix crash on logout (#1749) 2023-11-07 14:24:31 +01:00
renovate[bot]
d0092d8dbe
Update dependency io.sentry:sentry-android to v6.33.1 (#1752)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-11-07 13:31:28 +01:00
ElementBot
b2d0504ec7 Update screenshots 2023-11-07 12:08:26 +00:00
Benoit Marty
7bd2ccd2a9 FlowStepPage: make onBackClicked nullable and remove canGoBack. 2023-11-07 10:59:22 +01:00
Benoit Marty
163bc8703f Rename UserStoryFlowPage to FlowStepPage
Rename UserStoryFlowPage to FlowStepPage
2023-11-07 10:59:22 +01:00
Benoit Marty
3483eaaa00 Fix issue about modifier. 2023-11-07 10:57:34 +01:00
ElementBot
993f08e427 Update screenshots 2023-11-07 10:57:34 +01:00
Benoit Marty
3e3a7c5516 Let SecureBackupEnterRecoveryKeyView use UserStoryFlowPage. 2023-11-07 10:57:34 +01:00
Benoit Marty
256eb23acf Let SecureBackupEnableView use UserStoryFlowPage. 2023-11-07 10:53:21 +01:00
Benoit Marty
7e63f196d9 Use ButtonColumnMolecule 2023-11-07 10:53:21 +01:00
Benoit Marty
310bd5bb49 Let SecureBackupDisableView use UserStoryFlowPage. 2023-11-07 10:53:21 +01:00
Benoit Marty
85fa899b5d Let LogoutView use UserStoryFlowPage. 2023-11-07 10:53:21 +01:00
Benoit Marty
c77ebabcb2 Let SecureBackupSetupView use UserStoryFlowPage. 2023-11-07 10:53:21 +01:00
Benoit Marty
9fa6026483 Create UserStoryFlowPage.
This will reduce some boilerplate and copy pasting we have in the codebase.
2023-11-07 10:53:21 +01:00
renovate[bot]
74ccdf83f6
Update dependency org.matrix.rustcomponents:sdk-android to v0.1.67 (#1747)
* Update dependency org.matrix.rustcomponents:sdk-android to v0.1.67

* Fix breaking change in `RustMediaLoader`.

* Fix breaking change in `DefaultCallWidgetSettingsProvider`

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Marco Romano <marcor@element.io>
2023-11-07 07:53:24 +00:00
Benoit Marty
23c3e30876
Merge pull request #1745 from vector-im/feature/bma/lint
Feature/bma/lint
2023-11-06 18:50:22 +01:00
Benoit Marty
64b7c906db
Merge pull request #1742 from vector-im/sync-localazy
Sync Strings
2023-11-06 16:05:01 +01:00
Benoit Marty
5de8841d96 Upgrade lint to version 8.3.0-alpha11 and suppress false positive. 2023-11-06 16:03:16 +01:00
Benoit Marty
12ca31282e Remove dependency on material library. 2023-11-06 16:03:10 +01:00
Benoit Marty
9402421929 Let lint analysis the module :appconfig.
We had this warning:
Lint will treat :appconfig as an external dependency and not analyze it.
 * Recommended Action: Apply the 'com.android.lint' plugin to java library project :appconfig. to enable lint to analyze those sources.
2023-11-06 16:03:03 +01:00
Benoit Marty
9e63dfa9b8
Merge pull request #1738 from vector-im/feature/bma/AsyncView
Introduce AsyncView to avoid repeating ourselves
2023-11-06 15:43:18 +01:00
Benoit Marty
92763be1aa Fix Konsist test. Was causing issue with AsyncProvider : PreviewParameterProvider<Async<Unit>> 2023-11-06 15:00:46 +01:00
ElementBot
b8b5874d1a Update screenshots 2023-11-06 13:57:15 +00:00
Benoit Marty
e984b9bb5c Introduce AsyncViewDefaults for ProgressDialog 2023-11-06 10:42:15 +01:00
Benoit Marty
7bb5f3b056 BugReportView: show progress in the button, not as a dialog. 2023-11-06 10:09:41 +01:00
Benoit Marty
ffccbb5d90 Use AsyncView in SecureBackupEnterRecoveryKeyView 2023-11-06 10:09:41 +01:00
Benoit Marty
8cd4ac3303 Use AsyncView in RoomNotificationSettingsView and UserDefinedRoomNotificationSettingsView 2023-11-06 10:09:41 +01:00
Benoit Marty
fb4216c827 Use AsyncView in RoomDetailsEditView 2023-11-06 10:09:41 +01:00
Benoit Marty
f49a506d6a Use AsyncView in BugReportView 2023-11-06 10:09:41 +01:00
Benoit Marty
aaa89afe34 Use AsyncView in EditUserProfileView 2023-11-06 10:09:41 +01:00
Benoit Marty
6ad2c99576 Use AsyncView in EditDefaultNotificationSettingView 2023-11-06 10:09:41 +01:00
Benoit Marty
cc5321f65a Use AsyncView in NotificationSettingsView 2023-11-06 10:09:41 +01:00
Benoit Marty
1e09d9c65f Use AsyncView in ReportMessageView 2023-11-06 10:09:41 +01:00
Benoit Marty
31d1685709 Use AsyncView in OidcView 2023-11-06 10:09:41 +01:00
Benoit Marty
662b1f8f50 Use AsyncView in CreateRoomRootView 2023-11-06 10:09:41 +01:00
Benoit Marty
c6ee35f567 Use AsyncView in ConfigureRoomView 2023-11-06 10:09:41 +01:00
Benoit Marty
d700b0bc4e Introduce AsyncView to limit duplicated code. 2023-11-06 10:09:41 +01:00
bmarty
2fca8412b2 Sync Strings from Localazy 2023-11-06 08:23:40 +00:00
Benoit Marty
fe69db397f
Merge pull request #1731 from vector-im/feature/bma/variousCleanup
Konsist: check if sealed class could be sealed interface
2023-11-03 18:09:49 +01:00
Benoit Marty
6fda11aff0 Convert Data.Audio to data class, and implement equals and hashCode as suggested. 2023-11-03 17:32:38 +01:00
Benoit Marty
f37c0f459e
Merge pull request #1735 from vector-im/feature/bma/pinLockGracePeriod0
Pin lock grace period set to 0
2023-11-03 17:24:29 +01:00
renovate[bot]
befed299fc
Update showkase to v1.0.2 (#1383)
* Update showkase to v1.0.2

* Update screenshots

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2023-11-03 16:04:29 +01:00
Benoit Marty
9f30aa3108 Rename test. 2023-11-03 15:19:55 +01:00
Benoit Marty
21200df294 Konsist: check that if sealed interface is used in parameter of Composable, it has the @Stable or @Immutable annotation 2023-11-03 15:19:55 +01:00